Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Config Generation #58

Merged
merged 11 commits into from
Feb 2, 2024
Merged

Updates to Config Generation #58

merged 11 commits into from
Feb 2, 2024

Commits on Jan 25, 2024

  1. pr action commits ALL changes by default 

    on a recent test, all the depedencies got committed, again

We ONLY want changes in the config folder, so we must specify the add-paths parameter
    Abby Wheelis committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    aa91d07 View commit details
    Browse the repository at this point in the history

  2. more explanatory names 

    updating naming conditions to prevent duplication and keep track of the issue number
    Abby Wheelis committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    5f80165 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. admin access edits 

    strip off the leading and trailing whitespace so the emails are valid

set a failure when the list is too long
    Abby Wheelis committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a2ef78b View commit details
    Browse the repository at this point in the history

  2. better naming 

    rename to email_list (admin_list was duplicated) and actually instantiate the variable so the process works
    Abby Wheelis committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    14ecaea View commit details
    Browse the repository at this point in the history

  3. correct syntax mistake

    Abby Wheelis committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    c3385c1 View commit details
    Browse the repository at this point in the history

  4. add limit warning to the form itself

    Abby Wheelis committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    7751fa0 View commit details
    Browse the repository at this point in the history

  5. increase limit to 5 

    based on review comment - e-mission#49 (comment)
    Abby Wheelis committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    319d4d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. typo 

    comman -> comma
    @Abby-Wheelis
    Abby-Wheelis authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    9235d30 View commit details
    Browse the repository at this point in the history

  2. forcing lower case

    Abby Wheelis committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    93a9ad9 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. only push to lowercase once

    Abby Wheelis committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    ac04a89 View commit details
    Browse the repository at this point in the history

  2. misleading url instructions

    Abby Wheelis committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    4b06d9c View commit details
    Browse the repository at this point in the history