Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recursive watch #431

Closed
wants to merge 2 commits into from
Closed

Add recursive watch #431

wants to merge 2 commits into from

Conversation

0div
Copy link
Contributor

@0div 0div commented Aug 24, 2024

Description

  • users can now pass a onFileCreation listener via the Sandbox.create and Sandbox.connect methods.
  • Handling of recursive nature of events and tests reflect changes in envd
  • boyscouting: added a few cleanup functions that remove some created files during tests so that we don't have to restart envd to run subsequent tests

Tests

cd /packages/js-sdk
pnpm test

Copy link

changeset-bot bot commented Aug 24, 2024

⚠️ No Changeset found

Latest commit: 2902024

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

* onFileCreation only listens to CREATE events with the above
* onTestFinished cleanup function is awaited
@ValentaTomas ValentaTomas added feature New feature or request sdk Improvements or additions to SDKs labels Aug 30, 2024
@ValentaTomas ValentaTomas marked this pull request as draft September 10, 2024 01:13
@ValentaTomas ValentaTomas assigned ValentaTomas and 0div and unassigned ValentaTomas Oct 5, 2024
@jakubno jakubno deleted the branch e2b-dev:beta October 16, 2024 10:00
@jakubno jakubno closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request sdk Improvements or additions to SDKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants