Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WatchDir
now performs a recursive directory traversal and watches recursivelyWatchDirResponse
now return absolute paths instead of relative paths to avoid confusions.os.Lstat
is used instead ofos.Stat
to avoid following symbolic linksTest
For now, the tests in
js-sdk
add some indirect coverage to this implementationSide note on performance
WatchDir
at the root did not increase goroutine count (usually 4)