Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21313] Allow all @default annotation values for unions #380

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jul 17, 2024

Description

This PR enables the use of any @default annotation value for unions.
Depends on:

Required by:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v4.0.0 milestone Jul 17, 2024
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test case for this here

@EduPonz EduPonz force-pushed the feature/type_propagation_policy branch 2 times, most recently from 9fac5c7 to 2113f5e Compare July 18, 2024 10:13
EduPonz added 2 commits July 19, 2024 09:13
Signed-off-by: eduponz <eduardoponz@eprosima.com>
… value

Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the feature/type_propagation_policy branch from 2113f5e to 1969b40 Compare July 19, 2024 11:11
@EduPonz EduPonz requested a review from MiguelCompany July 19, 2024 11:11
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 19, 2024
MiguelCompany
MiguelCompany previously approved these changes Jul 22, 2024
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz requested review from MiguelCompany and removed request for MiguelCompany July 24, 2024 07:12
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit 4ba8926 into master Jul 24, 2024
4 checks passed
@MiguelCompany MiguelCompany deleted the feature/type_propagation_policy branch July 24, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants