Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21313] Type propagation policy #5081

Merged
merged 22 commits into from
Jul 26, 2024
Merged

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jul 17, 2024

Description

This PR adds a property policy to the DomainParticipant to control how types are propagated by EDP and Type Lookup Service.
The property name is fastdds.type_propagation
The property can take 4 values:

Value Register Type Object Send TypeInformation on EDP Receive TypeInformation on EDP Type Lookup replies
disabled NO NO IGNORED NO
enabled BOTH BOTH PROCESSED COMPLETE & COMPLETE_TO_MINIMAL
minimal_bandwidth MINIMAL MINIMAL Only MINIMAL PROCESSED MINIMAL
registration_only BOTH NO IGNORED NO

Related PRs:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v3.0.0 milestone Jul 17, 2024
@EduPonz EduPonz force-pushed the feature/type_propagation_policy branch 2 times, most recently from 7c88acb to 2248a57 Compare July 17, 2024 13:45
@EduPonz EduPonz marked this pull request as ready for review July 17, 2024 14:00
@elianalf elianalf added the needs-review PR that is ready to be reviewed label Jul 18, 2024
test/unittest/fastdds/utils/TypePropagationTests.cpp Outdated Show resolved Hide resolved
examples/cpp/xtypes/SubscriberApp.cpp Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/subscriber/DataReaderImpl.cpp Outdated Show resolved Hide resolved
test/examples/xtypes_complete.compose.yml Show resolved Hide resolved
@EduPonz EduPonz force-pushed the feature/type_propagation_policy branch 3 times, most recently from 9464f21 to 6287e85 Compare July 19, 2024 11:11
@EduPonz EduPonz requested a review from MiguelCompany July 19, 2024 11:11
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 19, 2024
@EduPonz EduPonz force-pushed the feature/type_propagation_policy branch from 6287e85 to 89fb2ff Compare July 20, 2024 04:53
@EduPonz EduPonz requested review from MiguelCompany and removed request for MiguelCompany July 20, 2024 04:53
@richiware richiware requested review from MiguelCompany and removed request for MiguelCompany July 23, 2024 07:56
@richiware richiware force-pushed the feature/type_propagation_policy branch 2 times, most recently from ab4778c to b937c61 Compare July 23, 2024 08:25
@richiware richiware requested review from MiguelCompany and removed request for MiguelCompany July 23, 2024 08:25
@richiware richiware force-pushed the feature/type_propagation_policy branch from 5315dd9 to 4835420 Compare July 24, 2024 06:02
@richiware richiware requested review from MiguelCompany and removed request for MiguelCompany July 24, 2024 06:03
EduPonz and others added 21 commits July 24, 2024 15:18
…propagation policy

Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
…code

Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
…irdparty

Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the feature/type_propagation_policy branch from 7e17d35 to 6bc41e5 Compare July 24, 2024 14:34
@MiguelCompany MiguelCompany self-requested a review July 24, 2024 14:37
…utexes

Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz requested review from MiguelCompany and removed request for MiguelCompany July 25, 2024 07:03
@EduPonz EduPonz merged commit 01cbcd1 into master Jul 26, 2024
16 of 17 checks passed
@EduPonz EduPonz deleted the feature/type_propagation_policy branch July 26, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants