Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21392] Refactor key hash calculation according to DDS X-Types 1.3 #381

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jul 19, 2024

Description

This PR refactors the key hash calculation as DDS-XTypes 1.3 specifies.

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Refactor key hash calculation according to DDS X-Types 1.3 [21392] Refactor key hash calculation according to DDS X-Types 1.3 Jul 19, 2024
@richiware richiware added this to the v4.0.0 milestone Jul 19, 2024
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware requested a review from MiguelCompany July 29, 2024 07:46
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 29, 2024
MiguelCompany
MiguelCompany previously approved these changes Jul 29, 2024
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI.

@MiguelCompany MiguelCompany merged commit b3ae5dc into master Jul 29, 2024
4 checks passed
@MiguelCompany MiguelCompany deleted the feature/21385 branch July 29, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants