-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21393] Add new tests for testing new key hash calculation according to DDS-XTypes 1.3 #5091
Conversation
135f721
to
e7db5cd
Compare
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Signed-off-by: eduponz <eduardoponz@eprosima.com>
e7db5cd
to
8769938
Compare
Signed-off-by: eduponz <eduardoponz@eprosima.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…are conditions. Let compare n bytes only Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
These former commits propose a fix for the
Bearing this in mind, the proposed fix makes the test only compare the first 10 bytes of the structure (in reality, the latter 10 bytes since the key hash is computed with BIG_ENDIAN). |
Description
This PR increases the number of tests of the DynamicTypes feature for testing the new key hash calculation according to DDS-XTypes 1.3
Depends on:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist