Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20275] Fix GitHub Windows CI #4347

Closed
wants to merge 6 commits into from

Conversation

JesusPoderoso
Copy link
Contributor

Description

GitHub action's Windows CI started failing in our libp11 and softHSM workflow steps.
This PR removes them temporally to pass remaining tests, and updates accordingly the default_ci.metas file to remove EPROSIMA_BUILD option (the one which runs those tests) and includes the remaining flags needed.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added the ci-pending PR which CI is running label Feb 1, 2024
@JesusPoderoso JesusPoderoso added this to the v2.13.2 milestone Feb 1, 2024
@JesusPoderoso JesusPoderoso self-assigned this Feb 1, 2024
JesusPoderoso and others added 5 commits February 1, 2024 11:55
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
… symlink install

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@EduPonz
Copy link

EduPonz commented Feb 7, 2024

Closed in favor of:

@EduPonz EduPonz closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants