Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20318] Fix and refactor Windows Github CI #4356

Merged
merged 9 commits into from
Feb 8, 2024
Merged

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Feb 7, 2024

Description

This PR:

  • Fixes Windows CI in Github (this has implied disabling PKCS#11 tests for now; reenabling them will be investigated in a different PR)
  • Refactors the workflow to use more of eProsima-CI features
  • Builds with warnings as errors
  • Uses Asio and TinyXML2 from thirdparty instead of choco installation because the post build steps of the test related CMake targets is not being able to find one of them (I assume TinyXML2) when running the test executable to discover the tests

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Changes are ABI compatible.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v2.13.2 milestone Feb 7, 2024
richiware
richiware previously approved these changes Feb 7, 2024
@EduPonz EduPonz force-pushed the hotfix/windows-ci branch 2 times, most recently from 2a6b667 to 97dbd4f Compare February 7, 2024 11:47
@EduPonz EduPonz added the no-test Skip CI tests if PR marked with this label label Feb 7, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Only use warnings as errors for Fast DDS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Do not override existing CXX_FLAGS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
.github/workflows/config/default_ci.meta Outdated Show resolved Hide resolved
.github/workflows/config/nightly.meta Outdated Show resolved Hide resolved
.github/workflows/reusable-windows-ci.yml Outdated Show resolved Hide resolved
.github/workflows/reusable-windows-ci.yml Outdated Show resolved Hide resolved
.github/workflows/reusable-windows-ci.yml Outdated Show resolved Hide resolved
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
richiware
richiware previously approved these changes Feb 7, 2024
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz merged commit 7adc833 into master Feb 8, 2024
11 checks passed
@EduPonz EduPonz deleted the hotfix/windows-ci branch February 8, 2024 11:02
@MiguelCompany
Copy link
Member

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Copy link
Contributor

mergify bot commented Feb 8, 2024

backport 2.12.x 2.11.x 2.10.x 2.6.x

✅ Backports have been created

EduPonz added a commit that referenced this pull request Feb 14, 2024
* Refs #20318: Fix passing of RUNTIME_LIST to test discovery

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Refactor windows workflow

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Compile warnings as errors

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Only use warnings as errors for Fast DDS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Do not override existing CXX_FLAGS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Use thirdparty for Asio and TinyXML2

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Add cancel-in-progress to sanitizer jobs

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Apply Ricardo's suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318. Avoid build error on default_macros_test

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20318: Adjust working dir for test report

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 7adc833)

# Conflicts:
#	.github/workflows/config/default_ci.meta
#	.github/workflows/config/nightly.meta
#	.github/workflows/reusable-windows-ci.yml
#	cmake/testing/GoogleTest.cmake
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
EduPonz added a commit that referenced this pull request Feb 14, 2024
* Fix and refactor Windows Github CI (#4356)

* Refs #20318: Fix passing of RUNTIME_LIST to test discovery

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Refactor windows workflow

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Compile warnings as errors

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Only use warnings as errors for Fast DDS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Do not override existing CXX_FLAGS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Use thirdparty for Asio and TinyXML2

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Add cancel-in-progress to sanitizer jobs

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Apply Ricardo's suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318. Avoid build error on default_macros_test

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20318: Adjust working dir for test report

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 7adc833)

# Conflicts:
#	.github/workflows/config/default_ci.meta
#	.github/workflows/config/nightly.meta
#	.github/workflows/reusable-windows-ci.yml
#	cmake/testing/GoogleTest.cmake
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Test report action does not run when no-test label is set (#4366)

* Refs #20400: Test report action does not run when no-test label is set

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Add GTest cmake options to nightly.meta

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Use test step conclusion to decide whether to run test report step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Apply Miguel's suggestion

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318. Add GTEST_INDIVIDUAL=ON

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Add test summary step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Use tagged version for test_reporter action

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20318: Enforce unique name for test artifacts

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz added a commit that referenced this pull request Feb 14, 2024
* Fix and refactor Windows Github CI (#4356)

* Refs #20318: Fix passing of RUNTIME_LIST to test discovery

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Refactor windows workflow

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Compile warnings as errors

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Only use warnings as errors for Fast DDS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Do not override existing CXX_FLAGS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Use thirdparty for Asio and TinyXML2

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Add cancel-in-progress to sanitizer jobs

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Apply Ricardo's suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318. Avoid build error on default_macros_test

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20318: Adjust working dir for test report

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 7adc833)

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Test report action does not run when no-test label is set (#4366)

* Refs #20400: Test report action does not run when no-test label is set

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Add GTest cmake options to nightly.meta

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Use test step conclusion to decide whether to run test report step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Apply Miguel's suggestion

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318. Add GTEST_INDIVIDUAL=ON

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Add test summary step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Use tagged version for test_reporter action

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20318: Enforce unique name for test artifacts

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz added a commit that referenced this pull request Feb 14, 2024
* Fix and refactor Windows Github CI (#4356)

* Refs #20318: Fix passing of RUNTIME_LIST to test discovery

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Refactor windows workflow

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Compile warnings as errors

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Only use warnings as errors for Fast DDS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Do not override existing CXX_FLAGS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Use thirdparty for Asio and TinyXML2

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Add cancel-in-progress to sanitizer jobs

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Apply Ricardo's suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318. Avoid build error on default_macros_test

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20318: Adjust working dir for test report

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 7adc833)

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Test report action does not run when no-test label is set (#4366)

* Refs #20400: Test report action does not run when no-test label is set

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Add GTest cmake options to nightly.meta

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Use test step conclusion to decide whether to run test report step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Apply Miguel's suggestion

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318. Add GTEST_INDIVIDUAL=ON

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Add test summary step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Use tagged version for test_reporter action

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20318: Enforce unique name for test artifacts

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz added a commit that referenced this pull request Feb 14, 2024
* Fix and refactor Windows Github CI (#4356)

* Refs #20318: Fix passing of RUNTIME_LIST to test discovery

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Refactor windows workflow

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Compile warnings as errors

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Only use warnings as errors for Fast DDS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Do not override existing CXX_FLAGS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Use thirdparty for Asio and TinyXML2

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Add cancel-in-progress to sanitizer jobs

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Apply Ricardo's suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318. Avoid build error on default_macros_test

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20318: Adjust working dir for test report

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 7adc833)

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Test report action does not run when no-test label is set (#4366)

* Refs #20400: Test report action does not run when no-test label is set

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Add GTest cmake options to nightly.meta

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Use test step conclusion to decide whether to run test report step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Apply Miguel's suggestion

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318. Add GTEST_INDIVIDUAL=ON

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Add test summary step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Use tagged version for test_reporter action

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20318: Enforce unique name for test artifacts

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz added a commit that referenced this pull request Feb 15, 2024
* Fix and refactor Windows Github CI (#4356)

* Refs #20318: Fix passing of RUNTIME_LIST to test discovery



* Refs #20318: Refactor windows workflow



* Refs #20318: Compile warnings as errors



Refs #20318: Only use warnings as errors for Fast DDS



Refs #20318: Do not override existing CXX_FLAGS



* Refs #20318: Use thirdparty for Asio and TinyXML2



* Refs #20318: Add cancel-in-progress to sanitizer jobs



* Refs #20318: Apply Ricardo's suggestions



* Refs #20318. Avoid build error on default_macros_test



* Refs #20318: Adjust working dir for test report



* Refs #20318: Uncrustify



---------




(cherry picked from commit 7adc833)



* Fix conflicts




* Test report action does not run when no-test label is set (#4366)

* Refs #20400: Test report action does not run when no-test label is set



* Refs #20400: Add GTest cmake options to nightly.meta



* Refs #20400: Use test step conclusion to decide whether to run test report step



* Refs #20400: Apply Miguel's suggestion



---------



* Refs #20318. Add GTEST_INDIVIDUAL=ON




* Refs #20318: Add test summary step



* Use tagged version for test_reporter action



* Refs #20318: Enforce unique name for test artifacts



---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz added a commit that referenced this pull request Feb 16, 2024
* Fix and refactor Windows Github CI (#4356)

* Fix and refactor Windows Github CI (#4356)

* Refs #20318: Fix passing of RUNTIME_LIST to test discovery

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Refactor windows workflow

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Compile warnings as errors

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Only use warnings as errors for Fast DDS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Do not override existing CXX_FLAGS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Use thirdparty for Asio and TinyXML2

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Add cancel-in-progress to sanitizer jobs

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Apply Ricardo's suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318. Avoid build error on default_macros_test

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20318: Adjust working dir for test report

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 7adc833)

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Test report action does not run when no-test label is set (#4366)

* Refs #20400: Test report action does not run when no-test label is set

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Add GTest cmake options to nightly.meta

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Use test step conclusion to decide whether to run test report step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Apply Miguel's suggestion

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318. Add GTEST_INDIVIDUAL=ON

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Add test summary step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Use tagged version for test_reporter action

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20318: Enforce unique name for test artifacts

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20318: Set Fast CDR version for CI to 2.1.x branch

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Use GTEST_INDIVIDUAL=ON

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz added a commit that referenced this pull request Feb 16, 2024
* Fix and refactor Windows Github CI (#4356)

* Fix and refactor Windows Github CI (#4356)

* Refs #20318: Fix passing of RUNTIME_LIST to test discovery

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Refactor windows workflow

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Compile warnings as errors

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Only use warnings as errors for Fast DDS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

Refs #20318: Do not override existing CXX_FLAGS

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Use thirdparty for Asio and TinyXML2

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Add cancel-in-progress to sanitizer jobs

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Apply Ricardo's suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318. Avoid build error on default_macros_test

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20318: Adjust working dir for test report

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Uncrustify

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 7adc833)

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Test report action does not run when no-test label is set (#4366)

* Refs #20400: Test report action does not run when no-test label is set

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Add GTest cmake options to nightly.meta

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Use test step conclusion to decide whether to run test report step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Apply Miguel's suggestion

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318. Add GTEST_INDIVIDUAL=ON

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20318: Add test summary step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Use tagged version for test_reporter action

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20318: Enforce unique name for test artifacts

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20318: Install OpenSSL 1.1.1

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants