-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom easyblock for flook that includes install step #3034
Conversation
The easyblock is used in easybuilders/easybuild-easyconfigs#19238 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
EasyBlock tests are in easybuilders/easybuild-easyconfigs#19238 and works great, thanks a lot @ahkole! |
@ahkole Would it make sense to also update the existing |
@boegel I think this would make sense yes. Looking at the other |
@ahkole Please do! |
The software flook (https://github.com/ElectronicStructureLibrary/flook) has an unconventional build system. It doesn't have a configure script and requires a manual config file, but it does have an install step. The currently available flook easyconfig uses the
MakeCp
generic easyblock which works fine in most cases but it doesn't automatically install the pkgconf that might be needed by other software to automatically detect that flook has been installed. This PR adds a new easyblock for flook that also performs the install step so that the pkgconf file is generated and installed.