-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{data}[GCC/11.3.0] flook v0.8.1 #19238
{data}[GCC/11.3.0] flook v0.8.1 #19238
Conversation
…1_flook.pc.in.patch
Note: the patch file is needed to fix the pkgconf template file |
@boegelbot: please test @ generoso EB_ARGS="--include-easyblocks-from-pr=3034" |
@ocaisa: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1813212536 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen2 EB_ARGS="--include-easyblocks-from-pr=3034" |
@ocaisa: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1813224923 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -0,0 +1,11 @@ | |||
diff --git a/flook.pc.in b/flook.pc.in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahkole Patch description is missing, do you mind opening a follow-up PR that add a short description of why this patch is needed on top, and mentions yourself as author (or includes a reference to source of the patch)?
Note that this implies updating the checksum of the patch in the flook
easyconfig as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @boegel, sure I can do that, no problem. I will do so immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requires:
(created using
eb --new-pr
)