Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{data}[GCC/11.3.0] flook v0.8.1 #19238

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

ahkole
Copy link
Contributor

@ahkole ahkole commented Nov 15, 2023

@ahkole
Copy link
Contributor Author

ahkole commented Nov 15, 2023

Note: the patch file is needed to fix the pkgconf template file flook.pc.in which doesn't correctly link to an external Lua library.

@ocaisa
Copy link
Member

ocaisa commented Nov 15, 2023

@boegelbot: please test @ generoso EB_ARGS="--include-easyblocks-from-pr=3034"

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=19238 EB_ARGS="--include-easyblocks-from-pr=3034" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19238 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12173

Test results coming soon (I hope)...

- notification for comment with ID 1813212536 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3034
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/3b8e3ab0018c033f02bcbc963ff695f7 for a full test report.

@ocaisa
Copy link
Member

ocaisa commented Nov 15, 2023

@boegelbot please test @ jsc-zen2 EB_ARGS="--include-easyblocks-from-pr=3034"

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19238 EB_ARGS="--include-easyblocks-from-pr=3034" EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19238 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3736

Test results coming soon (I hope)...

- notification for comment with ID 1813224923 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3034
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/28e5428b6ed7009795b0d13d691ff2bf for a full test report.

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa merged commit b63ade4 into easybuilders:develop Nov 15, 2023
9 checks passed
@@ -0,0 +1,11 @@
diff --git a/flook.pc.in b/flook.pc.in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahkole Patch description is missing, do you mind opening a follow-up PR that add a short description of why this patch is needed on top, and mentions yourself as author (or includes a reference to source of the patch)?

Note that this implies updating the checksum of the patch in the flook easyconfig as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @boegel, sure I can do that, no problem. I will do so immediately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel boegel added the update label Nov 22, 2023
@boegel boegel added this to the next release (4.9.0?) milestone Nov 22, 2023
@easybuilders easybuilders deleted a comment from boegelbot Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants