Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip flaky test in PyTorch 1.9.0 #16258

Merged
merged 1 commit into from
Oct 11, 2022
Merged

skip flaky test in PyTorch 1.9.0 #16258

merged 1 commit into from
Oct 11, 2022

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Sep 19, 2022 •
edited
Loading

(created using eb --new-pr)

Fixes #16233 reported by @boegel

@Flamefire
Copy link
Contributor Author

Flamefire commented Sep 19, 2022 •
edited
Loading

Test created with --stop=patch

Test report by @Flamefire
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
taurusml4 - Linux RHEL 7.6, POWER, 8335-GTX (power9le), 6 x NVIDIA Tesla V100-SXM2-32GB, 440.64.00, Python 2.7.5
See https://gist.github.com/aa1b09974b95129791bc10e9cf8e3763 for a full test report.

@boegel boegel added the bug fix label Oct 7, 2022
@boegel boegel added this to the next release (4.6.2?) milestone Oct 7, 2022
@boegel boegel changed the title skip flaky test in PyTorch 1.9 skip flaky test in PyTorch 1.9.0 Oct 7, 2022
@boegel
Copy link
Member

boegel commented Oct 8, 2022 •
edited
Loading

@Flamefire Seems like this is also relevant for PyTorch 1.11.0, see easybuilders/easybuild-easyblocks#2794 (comment) (although there we do allow a minimal number of failing tests).

Let's change the PyTorch 1.11.0 easyconfigs in a separate PR though (maybe as a part of #16339), so the test reports are more feasible, successful test report from my side is imminent for this PR...

@Flamefire
Copy link
Contributor Author

Possible actual fix has been pushed to PyTorch: pytorch/pytorch#86464

@boegel
Copy link
Member

boegel commented Oct 8, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3305.joltik.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), 1 x NVIDIA Tesla V100-SXM2-32GB, 510.85.02, Python 3.6.8
See https://gist.github.com/caa47e4756bf572ebe2422fead5537ac for a full test report.

boegel
boegel approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Oct 11, 2022

Going in, thanks @Flamefire!

@boegel boegel merged commit 6de62a2 into easybuilders:develop Oct 11, 2022
@Flamefire Flamefire deleted the 20220919171003_new_pr_PyTorch190 branch October 11, 2022 15:49
@Flamefire Flamefire mentioned this pull request Dec 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.6.2
2 participants
@Flamefire @boegel