-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add patches to fix or skip PyTorch 1.12.1 tests #16793
add patches to fix or skip PyTorch 1.12.1 tests #16793
Conversation
Test report by @Flamefire |
Test report by @boegel |
Test report by @branfosj |
@boegel I'd need the full log to say more about the failues. I started 3 jobs for this PR to see if any fails when run non-interactively. |
Test report by @Flamefire |
Test report by @Flamefire |
Test report by @Flamefire |
I added workarounds for the tests failing for @boegel :
|
Test report by @boegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @Flamefire! |
(created using
eb --new-pr
)This skips a test which times out and is the only remaining failure: #16484 (comment)
In particular it is
distributed/_shard/sharded_tensor/test_sharded_tensor
and the patch is already used in the PyTorch 1.11 and 1.12-foss-2021b ECs but was missed in this one. It seems to be related to A100 GPUs so only required for the CUDA version.Error looks like this: