-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sure that Python dependency is actually used for VTK 9.0.1 #16741
make sure that Python dependency is actually used for VTK 9.0.1 #16741
Conversation
@@ -54,6 +54,7 @@ configopts += "-DOPENGL_gl_LIBRARY=$EBROOTMESA/lib/libGL.%s " % SHLIB_EXT | |||
configopts += "-DOPENGL_INCLUDE_DIR=$EBROOTMESA/include " | |||
# Python | |||
configopts += "-DVTK_WRAP_PYTHON=ON -DVTK_PYTHON_VERSION=3 -DVTK_PYTHON_OPTIONAL_LINK=OFF " | |||
configopts += '-DPython3_EXECUTABLE=$EBROOTPYTHON/bin/python ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried
configopts += "-DPython3_ROOT_DIR=$EBROOTPYTHON "
which appears in later easyconfigs for VTK, but that didn't work:
== 2022-11-24 16:49:59,340 run.py:624 INFO cmd " cmake -DCMAKE_INSTALL_PREFIX=/project/def-sponsor00/easybuild/software/VTK/9.0.1-foss-2021a -DCMAKE_BUILD_TYPE=Release -DCMAKE_SYSROOT=/cvmfs/pilot.eessi-hpc.org/versions/2021.12/compat/linux/x86_64 -DCMAKE_C_COMPILER='/project/def-sponsor00/easybuild/software/OpenMPI/4.1.1-GCC-10.3.0/bin/mpicc' -DCMAKE_C_FLAGS='-O2 -ftree-vectorize -march=native -fno-math-errno' -DCMAKE_CXX_COMPILER='/project/def-sponsor00/easybuild/software/OpenMPI/4.1.1-GCC-10.3.0/bin/mpicxx' -DCMAKE_CXX_FLAGS='-O2 -ftree-vectorize -march=native -fno-math-errno' -DCMAKE_Fortran_COMPILER='/project/def-sponsor00/easybuild/software/OpenMPI/4.1.1-GCC-10.3.0/bin/mpifort' -DCMAKE_Fortran_FLAGS='-O2 -ftree-vectorize -march=native -fno-math-errno' -DCMAKE_SKIP_RPATH=ON -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_FIND_USE_PACKAGE_REGISTRY=FALSE -DOPENGL_glu_LIBRARY=$EBROOTLIBGLU/lib/libGLU.so -DOPENGL_gl_LIBRARY=$EBROOTMESA/lib/libGL.so -DOPENGL_INCLUDE_DIR=$EBROOTMESA/include -DVTK_WRAP_PYTHON=ON -DVTK_PYTHON_VERSION=3 -DVTK_PYTHON_OPTIONAL_LINK=OFF -DPython3_ROOT_DIR=$EBROOTPYTHON -DVTK_USE_MPI=ON -DCMAKE_INSTALL_LIBDIR=lib /project/60005/easybuild/build/VTK/9.0.1/foss-2021a/VTK-9.0.1/" exited with exit code 0 and output:
-- Found Python3: /cvmfs/pilot.eessi-hpc.org/versions/2021.12/compat/linux/x86_64/usr/bin/python3.10 (found suitable version "3.10.0", minimum required is "3.2") found components: Interpreter Development.Module Development.Embed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should also try and check whether the -DPython3_ROOT_DIR
is really correct, also when a newer system Python version is available too
@boegelbot: please test @ generoso |
@ocaisa: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1326678805 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @boegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @ocaisa! |
(created using
eb --new-pr
)edit (by @boegel): this fixes the following compilation error:
Culprit is system Python 3.10 being used, see also https://gitlab.kitware.com/paraview/paraview/-/issues/21511 and EESSI/software-layer#204