Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure that Python dependency is actually used for VTK 9.0.1 #16741

Merged
merged 1 commit into from
Nov 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions easybuild/easyconfigs/v/VTK/VTK-9.0.1-foss-2020b.eb
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ configopts += "-DOPENGL_gl_LIBRARY=$EBROOTMESA/lib/libGL.%s " % SHLIB_EXT
configopts += "-DOPENGL_INCLUDE_DIR=$EBROOTMESA/include "
# Python
configopts += "-DVTK_WRAP_PYTHON=ON -DVTK_PYTHON_VERSION=3 -DVTK_PYTHON_OPTIONAL_LINK=OFF "
configopts += '-DPython3_EXECUTABLE=$EBROOTPYTHON/bin/python '
Copy link
Member Author

@ocaisa ocaisa Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried

configopts += "-DPython3_ROOT_DIR=$EBROOTPYTHON "

which appears in later easyconfigs for VTK, but that didn't work:

== 2022-11-24 16:49:59,340 run.py:624 INFO cmd " cmake -DCMAKE_INSTALL_PREFIX=/project/def-sponsor00/easybuild/software/VTK/9.0.1-foss-2021a -DCMAKE_BUILD_TYPE=Release -DCMAKE_SYSROOT=/cvmfs/pilot.eessi-hpc.org/versions/2021.12/compat/linux/x86_64 -DCMAKE_C_COMPILER='/project/def-sponsor00/easybuild/software/OpenMPI/4.1.1-GCC-10.3.0/bin/mpicc' -DCMAKE_C_FLAGS='-O2 -ftree-vectorize -march=native -fno-math-errno' -DCMAKE_CXX_COMPILER='/project/def-sponsor00/easybuild/software/OpenMPI/4.1.1-GCC-10.3.0/bin/mpicxx' -DCMAKE_CXX_FLAGS='-O2 -ftree-vectorize -march=native -fno-math-errno' -DCMAKE_Fortran_COMPILER='/project/def-sponsor00/easybuild/software/OpenMPI/4.1.1-GCC-10.3.0/bin/mpifort' -DCMAKE_Fortran_FLAGS='-O2 -ftree-vectorize -march=native -fno-math-errno' -DCMAKE_SKIP_RPATH=ON -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_FIND_USE_PACKAGE_REGISTRY=FALSE -DOPENGL_glu_LIBRARY=$EBROOTLIBGLU/lib/libGLU.so -DOPENGL_gl_LIBRARY=$EBROOTMESA/lib/libGL.so -DOPENGL_INCLUDE_DIR=$EBROOTMESA/include -DVTK_WRAP_PYTHON=ON -DVTK_PYTHON_VERSION=3 -DVTK_PYTHON_OPTIONAL_LINK=OFF -DPython3_ROOT_DIR=$EBROOTPYTHON -DVTK_USE_MPI=ON -DCMAKE_INSTALL_LIBDIR=lib /project/60005/easybuild/build/VTK/9.0.1/foss-2021a/VTK-9.0.1/" exited with exit code 0 and output:
-- Found Python3: /cvmfs/pilot.eessi-hpc.org/versions/2021.12/compat/linux/x86_64/usr/bin/python3.10 (found suitable version "3.10.0", minimum required is "3.2") found components: Interpreter Development.Module Development.Embed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should also try and check whether the -DPython3_ROOT_DIR is really correct, also when a newer system Python version is available too

# Other
configopts += "-DVTK_USE_MPI=ON "
configopts += "-DCMAKE_INSTALL_LIBDIR=lib"
Expand Down
1 change: 1 addition & 0 deletions easybuild/easyconfigs/v/VTK/VTK-9.0.1-foss-2021a.eb
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ configopts += "-DOPENGL_gl_LIBRARY=$EBROOTMESA/lib/libGL.%s " % SHLIB_EXT
configopts += "-DOPENGL_INCLUDE_DIR=$EBROOTMESA/include "
# Python
configopts += "-DVTK_WRAP_PYTHON=ON -DVTK_PYTHON_VERSION=3 -DVTK_PYTHON_OPTIONAL_LINK=OFF "
configopts += '-DPython3_EXECUTABLE=$EBROOTPYTHON/bin/python '
# Other
configopts += "-DVTK_USE_MPI=ON "
configopts += "-DCMAKE_INSTALL_LIBDIR=lib"
Expand Down