-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{vis}[GCCcore/11.3.0] pygraphviz v1.10 w/ Python 3.10.4 #17518
{vis}[GCCcore/11.3.0] pygraphviz v1.10 w/ Python 3.10.4 #17518
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
@boegelbot: please test @ generoso |
@lexming: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1466607890 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen2 |
@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1467115329 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@@ -0,0 +1,33 @@ | |||
easyblock = 'PythonBundle' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you comment (just here in the PR, it doesn't need to end up in the EasyConfig) why you changed this to PythonBundle? I don't particularly mind - if it works it works - but it might be good to log it for posterity :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know what, I'll not block the merge over this. Still, would be nice to add it as a comment after the merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now is mostly a matter of preference, basically trying to consolidate around a single easyblock for all installations of Python packages. There is an open issue about this #15639 . But it is not mandatory (yet).
Test report by @casparvl |
Going in, thanks @lexming! |
(created using
eb --new-pr
)Changelog:
GCCcore
as graphviz moved down as well