Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{vis}[GCCcore/11.3.0] pygraphviz v1.10 w/ Python 3.10.4 #17518

Merged

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Mar 13, 2023

(created using eb --new-pr)

Changelog:

  • move down to GCCcore as graphviz moved down as well
  • converted to PythonBundle

@boegelbot

This comment was marked as outdated.

@lexming
Copy link
Contributor Author

lexming commented Mar 13, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=17518 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17518 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10459

Test results coming soon (I hope)...

- notification for comment with ID 1466607890 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/7373bcf8b799648162d8e06c487ac24a for a full test report.

@casparvl
Copy link
Contributor

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17518 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17518 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2347

Test results coming soon (I hope)...

- notification for comment with ID 1467115329 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/d47254ae466d0dda7098c1aff762d2b8 for a full test report.

@@ -0,0 +1,33 @@
easyblock = 'PythonBundle'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment (just here in the PR, it doesn't need to end up in the EasyConfig) why you changed this to PythonBundle? I don't particularly mind - if it works it works - but it might be good to log it for posterity :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what, I'll not block the merge over this. Still, would be nice to add it as a comment after the merge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now is mostly a matter of preference, basically trying to consolidate around a single easyblock for all installations of Python packages. There is an open issue about this #15639 . But it is not mandatory (yet).

@casparvl casparvl added this to the 4.x milestone Mar 13, 2023
@casparvl
Copy link
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
tcn375.local.snellius.surf.nl - Linux Rocky Linux 8.7, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/798abea3f43099024aab5636aebd7ee7 for a full test report.

@casparvl casparvl modified the milestones: 4.x, next release (4.7.1) Mar 13, 2023
@casparvl
Copy link
Contributor

Going in, thanks @lexming!

@casparvl casparvl merged commit b981d52 into easybuilders:develop Mar 13, 2023
@lexming lexming deleted the 20230313153828_new_pr_pygraphviz110 branch March 14, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants