Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix post-install command for SuperLU_DIST in case library prefix is lib instead of lib64 #20162

Merged

Conversation

casparvl
Copy link
Contributor

@casparvl casparvl commented Mar 20, 2024

(created using eb --new-pr)

SuperLU_DIST currently has the following postinstallcmds:

postinstallcmds = [
    "rm %(installdir)s/lib64/libsuperlu.a",  # remove broken symlink to libsuperlu.a
]

However, on my system, this leads to a failure: the SuperLU_DIST libraries are installed in %(installdir)s/lib instead of %(installdir)s/lib64. Thus, the rm fails since the directory doesn't exist.

Proposed solution:

# remove broken symlink to libsuperlu.a
postinstallcmds = [
    "if[ -f %(installdir)s/lib64/libsuperlu.a ]; then rm %(installdir)s/lib64/libsuperlu.a; fi",
    "if[ -f %(installdir)s/lib/libsuperlu.a ]; then rm %(installdir)s/lib/libsuperlu.a; fi"
]

This should be safe for everyone :) And everyone will need it if we merge easybuilders/easybuild-easyblocks#3227

@casparvl casparvl changed the title Fix issue in case library prefix is lib instead of lib64 SuperLU_DIST fix issue in case library prefix is lib instead of lib64 Mar 20, 2024
@casparvl
Copy link
Contributor Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=20162 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20162 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13150

Test results coming soon (I hope)...

- notification for comment with ID 2009590625 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/1d95d59a07db49a694bcf4e35562f017 for a full test report.

@casparvl casparvl marked this pull request as draft March 20, 2024 13:45
@easybuilders easybuilders deleted a comment from boegelbot Mar 20, 2024
@easybuilders easybuilders deleted a comment from boegelbot Mar 20, 2024
@casparvl
Copy link
Contributor Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=20162 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20162 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13152

Test results coming soon (I hope)...

- notification for comment with ID 2009638077 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Contributor Author

Test report by @casparvl
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/30c473d704f2cd5061d4bed58fc3aec8 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/c4b719c035983495ecaea367b8353891 for a full test report.

@casparvl
Copy link
Contributor Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20162 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20162 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3813

Test results coming soon (I hope)...

- notification for comment with ID 2009658790 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/12904e2e24070ba2c2b571c03d1ac722 for a full test report.

@casparvl casparvl marked this pull request as ready for review March 20, 2024 15:48
@smoors
Copy link
Contributor

smoors commented Mar 21, 2024

should not be needed if you apply easybuilders/easybuild-framework#4435

@casparvl
Copy link
Contributor Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20162 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20162 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3825

Test results coming soon (I hope)...

- notification for comment with ID 2012290717 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/6d747cade548d6855e2efc6982e16cd6 for a full test report.

@smoors smoors added this to the release after 4.9.0 milestone Mar 21, 2024
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Mar 21, 2024

Going in, thanks @casparvl!

@smoors smoors merged commit e9566be into easybuilders:develop Mar 21, 2024
9 checks passed
@boegel boegel changed the title SuperLU_DIST fix issue in case library prefix is lib instead of lib64 fix post-install command for SuperLU_DIST in case library prefix is lib instead of lib64 Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants