create lib -> lib64 symlink (or vice versa) *before* running postinstallcmds

[ocaisa]

Not having the symlinks in place means that postinstallcmds that rely on using/modifying something in the library directory have to use tricks to figure out the correct location.

[ocaisa]

See https://github.com/easybuilders/easybuild-easyconfigs/pull/19386/files#diff-380839b61c2724c1344f21dd480f4a74bfecce9569eaa1a7400c9c8b8364c95fR24 and libSBML in easybuilders/easybuild-easyconfigs#19488

[smoors]

this will require fixing Brunsli easyconfigs due to lib* wildcard:

postinstallcmds = [ 
    "mkdir %(installdir)s/bin",
    "cp dbrunsli %(installdir)s/bin/",
    "cp libbrunsli*.a %(installdir)s/lib*/",
    "cp libbrunsli*.%s %%(installdir)s/lib*/" % SHLIB_EXT,
]

[boegel]

@ocaisa This is a "breaking" change, so I'm re-targeting this to EasyBuild 5.0

@smoors You're right... How did you find that particular easyconfig? Any others that may be hit by this?

[smoors]

@smoors You're right... How did you find that particular easyconfig? Any others that may be hit by this?

quick and dirty regex search on lib* after postinstallcmds. did not see any other issues, but may have missed some.

[boegel]

@smoors You're right... How did you find that particular easyconfig? Any others that may be hit by this?

quick and dirty regex search on lib* after postinstallcmds. did not see any other issues, but may have missed some.

Brunsli is the only case I can find, and there we can make sure it works regardless of the order of lib/lib64 symlinks vs postinstallcmds by specifying -DCMAKE_INSTALL_LIBDIR=lib so stuff never ends up in <prefix>/lib64 (before we symlink), see:

• make sure that Brunsli libraries are installed into lib easybuild-easyconfigs#19805

[boegel]

lgtm