Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Team verwalten: Rollen #1415

Closed
32 of 33 tasks
BacLuc opened this issue May 14, 2021 · 3 comments
Closed
32 of 33 tasks

Team verwalten: Rollen #1415

BacLuc opened this issue May 14, 2021 · 3 comments
Assignees
@BacLuc
Milestone
MVP (v3.0)

Comments

@BacLuc
Copy link
Contributor

BacLuc commented May 14, 2021 •
edited
Loading

Spezifikation:

Rollen

  • Gast wählbar; readonly
    • Lese-Recht
    • Mit Materialliste
    • Kann Zuteilungen haben
  • Member
    • Lese-Recht
      • Admin
      • Team
    • Schreiben
      • Material
      • Story
      • Picasso / Inhalte
  • Manager
    • Schreiben alles

Todo:

Programm:
v-calendar ist nicht wirklich für einen readonly mode ausgelegt.

Aktivität Detail ansicht #1416

  • Guest
    • Layout bearbeiten Knopf ausblenden
    • Klick auf Category -> Category Edit ausblenden
    • Wenn man auf den Activity Namen klickt wird dieser editierbar -> deaktivieren
    • Location Text disablen
    • ScheduleEntry Hinzufügen/löschen etc ausblenden Does not seem to be implemented in the near future
    • Responsible DropDown disablen
    • ContentNodes: Icon ändern disablen
    • ContentNodes: Menu entfernen
    • ContentNodes: Textareas disablen

Story #1416

  • Guest
    • Editierbar Knopf disablen

Team

  • Guest/Member
    • Dropdown für Rolle disablen
    • Deactivate Knopf entfernen (ausser bei eigenen)
    • Resend Email Knopf entfernen
    • Invite Area entfernen
    • Delete Knopf entfernen
  • Manager
    • Wenn nur noch ein Manager im Team: Dropdown für Manager disablen, deactivate Knopf disablen, beides mit Tooltip: "Es muss mindestens ein Manager im Lager verbleiben"

Materials

  • Guest
    • Felder in Materiallist disablen (Auch Menu für löschen)
    • Hinzufügen row entfernen

Print

  • Nothing to do

Admin

  • Guest/Member
    • Textfelder disablen
    • Periods editieren disablen (add knopf weg, edit + menu weg
    • Danger Zone nicht anzeigen Hide danger zone if not manager #1382
    • Activity Categories: add weg, Edit Knopf bei der Category weg, Edit Layout weg, Delete weg
    • Material-list: create/edit/delete weg

Further improvements:

  • Make UX for disabled Links better:
    Remove hover on disabled links -> e-href component
    Remove hover on disabled buttons -> e-button
@BacLuc BacLuc mentioned this issue May 14, 2021
Open
18 tasks
@BacLuc BacLuc self-assigned this May 14, 2021
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue May 14, 2021
@BacLuc
Collaborators.vue: make invitation as guest possible
23912af 
Issue: ecamp#1415
@BacLuc BacLuc mentioned this issue May 14, 2021
Merged
27 tasks
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue May 14, 2021
@BacLuc
Collaborators.vue: make invitation as guest possible
d1cae1b 
Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
Collaborators.vue: make invitation as guest possible
7ff466d 
And allow guest to fetch camp entities.

Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
frontend/Activity.vue: disable editing activities for guests
9ac851e 
For that we have to propagate a disabled property to all involved components.

Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
frontend/Story.vue: disable editable switch if user is not collaborator
6afa4cb 
Pass camp as function instead of object into campRoleMixin.

Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
frontend/Collaborators.vue: enable/show edit functions only for manager
e45f9f8 
Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
frontend/CollaboratorListItem.vue: disable dropdown and deactivate bu…
469aad3 
…tton for last manager

Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
frontend/CollaboratorListItem.vue: disable dropdown and deactivate bu…
56b73ff 
…tton for last manager

But allow deactivating your own CampCollaboration, as long as
you are not the last manager.

Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
frontend/Story.vue: disable editable switch if user is guest
7b0eec8 
Pass camp as function instead of object into campRoleMixin.

Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
frontend/Collaborators.vue: enable/show edit functions only for manager
3a49056 
Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
frontend/CollaboratorListItem.vue: disable dropdown and deactivate bu…
c2ee1d9 
…tton if not manager

But allow deactivating your own CampCollaboration, as long as
you are not the last manager.
Prohibit the removal of the last manager.

Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
frontend/PeriodMaterialLists.vue: disable if user is guest
ac34f98 
Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
frontend/Admin.vue: disable if user is not manager
ef27e47 
Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
frontend/Collaborators.vue: enable edit functions only for manager
180455c 
But allow deactivating your own CampCollaboration, as long as
you are not the last manager.
Prohibit the removal of the last manager.
In this view, removing the buttons didn't look well, so i disabled them.

Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
frontend/CollaboratorListItem.vue: add tooltip to explain that you ca…
862e9cf 
…nnot delete the last manager

I could not use the component directly as activator, because
it is disabled when the tooltip should be shown, and then it does
not activate the tooltip.

Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
frontend/PeriodMaterialLists.vue: disable if user is guest
0dc335e 
Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
frontend/Admin.vue: disable if user is not manager
7cafc29 
Issue: ecamp#1415
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jun 6, 2021
@BacLuc
backend/content-type: allow guest to fetch the entities of content-nodes
81de17a 
In these content-types, the ACL is defined in the Module.php.
Adapt them according to 7ff466d.

Issue: ecamp#1415
@carlobeltrame
Copy link
Member

@BacLuc ist der Teil Guest wirklich noch offen oder hast du das inzwischen umgesetzt?

@BacLuc
Copy link
Contributor Author

BacLuc commented Jan 8, 2022

@BacLuc ist der Teil Guest wirklich noch offen oder hast du das inzwischen umgesetzt?

Leider nein. Das Programm muss man noch read only machen, und in der Aktivitäts Ansicht das hinzufügen von ScheduleEntries für Guests disablen. (Wenn es dann implementiert wird).

BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Jan 9, 2022
@BacLuc
frontend: disable editing for guests in CampProgram.vue
126876b 
Disable the edit switch.
Add tooltip that guests know why they can't edit the picasso.
Don't show the add button.

Issue: ecamp#1415
@BacLuc BacLuc mentioned this issue Jan 9, 2022
Merged
@manuelmeister manuelmeister added this to the MVP (v3.0) milestone Sep 20, 2022
@BacLuc
Copy link
Contributor Author

BacLuc commented Feb 14, 2023

I will close this issue.
When modifying ScheduleEntries on the Activity View is implemented, the ACL have to be implemented correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BacLuc BacLuc

Labels
None yet
Projects
v3 Epics
Status: Done
Milestone
MVP (v3.0)
Development

No branches or pull requests
3 participants
@BacLuc @manuelmeister @carlobeltrame