frontend: disable editing for guests in CampProgram.vue #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable the edit switch. Add tooltip that guests know why they can't edit the picasso. Don't show the add button. Issue: ecamp#1415
carlobeltrame
approved these changes
Jan 9, 2022
Comment on lines
+69
to
+71
| camp () { | ||
| return this.period().camp() | ||
| } |
There was a problem hiding this comment.
@usu genau aus diesem Grund wäre wohl das CampRoleMixin besser ein composable, oder? Dann wäre garantiert, dass es ein Camp hat.
There was a problem hiding this comment.
Ja, genau. Dann würdest du das Camp explizit als Parameter an das Composable übergeben.
Mit dem Mixin hat's halt diese explizite Interface-Definition nicht: Du musst selbst wissen, dass das Mixin this.camp erwartet (bzw. über trial und error herausfinden).
manuelmeister
approved these changes
Jan 10, 2022
usu
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the edit switch.
Add tooltip that guests know why they can't edit the picasso.
Don't show the add button.
Issue: #1415
Danke @usu für die vorarbeit