Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): upgrade to api-platform 3.0 #2984

Closed
wants to merge 39 commits into from

Conversation

usu
Copy link
Member

@usu usu commented Sep 17, 2022

ToDo

  • check performance timings (sanity check before/after)
  • refactor/fix tests for state providers and processors
  • fix phpstan/psalm warning
  • review deprecation warnings

Stuff for separate PRs

  • Review changes done in https://github.com/api-platform/api-platform and take over what makes sense
  • Our two DTOs Invitation and ResetPassword use slightly different concepts on how to return data. Review best practices for DTO in api-platform v3 and implement consistently for both DTOs.
  • Review if we want to support multiple ApiResources in our various extensions (UriTemplateFactory, etc.)
  • Register upstream issues

@usu usu added the Meeting Discuss Am nächsten Core-Meeting besprechen label Oct 21, 2022
@usu
Copy link
Member Author

usu commented Oct 21, 2022

I've implemented 2 examples for State Processors (=replacement of Data Persisters).

@ecampcore: Would be nice to review + discuss this latest in the next meeting. After that we could migrate the remaining data persisters.

Raw example (no abstraction; as per Api-Platform documentation)

ActivityCreateProcessor
ActivityRemoveProcessor

Abstracted example (automatic split of before/after logic + property change listeners)

This is is similar as we had it before. However we don't need the separation between various operations and custom actions anymore, as we can now define a separate processor per action out of the box.

CampCollaborationCreateProcessor
CampCollaborationResendInvitationProcessor
CampCollaborationUpdateProcessor

@usu usu removed the Meeting Discuss Am nächsten Core-Meeting besprechen label Nov 14, 2022
@usu usu marked this pull request as ready for review November 19, 2022 10:17
@usu usu closed this Nov 19, 2022
@usu usu mentioned this pull request Nov 19, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant