-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(api): upgrade to api-platform 3.0 #3176
Conversation
…space + fix the same test: testGetSingleDayIsAllowedForMember
2ca094b
to
2a3d2ff
Compare
@ecampcore I think this would be ready for another check-up from you guys. Major comments should all be implemented. Last pending point is sanity check on performance. On my local machine I got inconsistent result in both directions. Want to check on the deployment directly, but not really working at the moment. Will try again later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Just found the one commented test which was moved, so you could delete it now.
Looked at the coverage, and its still here.
(Don't know where the -0.3 percent are lost).
Could not go through anything very thorough, but i think with another approve it will be good enough.
Thank you very much @usu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
🥳 |
Superseded #2984 (had to create a new PR, because test workflows didn't run on the old one anymore)
ToDo
Stuff for separate PRs
Register upstream issues