Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): upgrade to api-platform 3.0 #3176

Merged
merged 80 commits into from
Jan 24, 2023
Merged

Conversation

usu
Copy link
Member

@usu usu commented Nov 19, 2022

Superseded #2984 (had to create a new PR, because test workflows didn't run on the old one anymore)

ToDo

Stuff for separate PRs

  • Review changes done in https://github.com/api-platform/api-platform and take over what makes sense
  • Review if we want to support multiple ApiResources in our various extensions (UriTemplateFactory, etc.)
  • Register upstream issues
  • Plural naming for /reset_password endpoint
  • Test coverage for data providers

@usu usu added the deploy! Creates a feature branch deployment for this PR label Dec 17, 2022
@usu
Copy link
Member Author

usu commented Dec 17, 2022

@ecampcore I think this would be ready for another check-up from you guys. Major comments should all be implemented. Last pending point is sanity check on performance. On my local machine I got inconsistent result in both directions. Want to check on the deployment directly, but not really working at the moment. Will try again later.

@usu usu removed the deploy! Creates a feature branch deployment for this PR label Dec 28, 2022
Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Just found the one commented test which was moved, so you could delete it now.

Looked at the coverage, and its still here.
(Don't know where the -0.3 percent are lost).

Could not go through anything very thorough, but i think with another approve it will be good enough.

Thank you very much @usu

api/tests/State/InvitationAcceptProcessorTest.php Outdated Show resolved Hide resolved
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@usu usu merged commit 84d5080 into ecamp:devel Jan 24, 2023
@manuelmeister
Copy link
Member

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants