Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace images used by system tests to avoid Docker Hub rate limit #354

Closed
windsource opened this issue Aug 22, 2024 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request. Issue will appear in the change log "Features" good first issue Good for newcomers
Milestone

Comments

@windsource
Copy link
Contributor

windsource commented Aug 22, 2024

Description

Currently we use images from Docker Hub for system tests like e.g. docker.io/library/nginx. As Docker Hub as a quite strict rate limit which is bound to an IP address when not logged in, that causes problems when many users share an IP address like in a corporate environment. But as the system tests are also executed in Github Actions that problem might occur there as well, depended on how the IP address of the VM has been used before by other users.

For that reason we should avoid using images from Docker Hub and use other container registries like ghcr.io. We could mirror the required images on ghcr.io/eclipse-ankaios.

Goals

Do not use images from Docker Hub for system and integration tests anymore.

Final result

Summary

Moved images that are used in tests to ghcr.io/eclipse-ankaios and only allow those images in tests.

@windsource windsource added enhancement New feature or request. Issue will appear in the change log "Features" good first issue Good for newcomers labels Aug 22, 2024
@windsource windsource self-assigned this Aug 22, 2024
windsource added a commit that referenced this issue Aug 22, 2024
@windsource
Copy link
Contributor Author

So currrently the following images are used in tests:

  • docker.io/alpine:latest
  • docker.io/nginx:latest

windsource added a commit that referenced this issue Aug 22, 2024
windsource added a commit that referenced this issue Aug 27, 2024
windsource added a commit that referenced this issue Aug 28, 2024
inf17101 pushed a commit that referenced this issue Aug 28, 2024
* Add CI check, that docker hub is not used in tests

Issue-Id: #354

* Use mirrored images for test

Issue-Id: #354

* Use whitelist rather than blacklist

Issue-Id: #354

* Add registry  to system tests docs

Issue-Id: #354
@krucod3 krucod3 added this to the v0.5 milestone Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. Issue will appear in the change log "Features" good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants