Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent docker.io images in tests due to rate limit #357

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

windsource
Copy link
Contributor

@windsource windsource commented Aug 22, 2024

Issue-Id: #354

Definition of Done

The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.

Makefile Outdated Show resolved Hide resolved
@inf17101
Copy link
Contributor

@windsource: Changes are all good. Maybe in addition, we can put a note box into the system test creation user doc that we do not support external hub images.

Copy link
Contributor

@inf17101 inf17101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test user documentation is adapted.
LGTM 👍

@inf17101 inf17101 merged commit 262e049 into main Aug 28, 2024
10 checks passed
@inf17101 inf17101 deleted the 354_no_docker_hub_images-for_test branch August 28, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants