Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeated scrolling with mouse wheel causes UI to freeze due label rendering #225

Closed
bhufmann opened this issue Dec 14, 2022 · 0 comments · Fixed by #226
Closed

Repeated scrolling with mouse wheel causes UI to freeze due label rendering #225

bhufmann opened this issue Dec 14, 2022 · 0 comments · Fixed by #226
Assignees
@hoangphamEclipse
Labels
bug Something isn't working

Comments

@bhufmann
Copy link
Collaborator

When running the timeline-chart with the theia-trace-extension and zooming many times with the mouse wheel in a short time periods, causes the UI to be very unresponsive up to a point that it freezes the UI.

Preliminary investigation shows that the main culprit is the clearing and recreating of the pixi BitmapText causes the issue. Which is executed a lot of times.

image
@bhufmann bhufmann added the bug Something isn't working label Dec 14, 2022
hoangphamEclipse added a commit to hoangphamEclipse/timeline-chart that referenced this issue Dec 19, 2022
@hoangphamEclipse
Improve rendering for text labels
9b952a3 
Currently, when the timeline chart renders text labels for states, it deletes all
existing labels, then creates new labels, and adds them to the graph. This is not
efficient and makes rendering of the labels sluggish when zooming in and out of the
graph. This commit removes the code that delete the text labels objects on every
re-render, and updates the text content of the labels instead of re-creating them.

Fixes eclipse-cdt-cloud#225.

Signed-off-by: Hoang Thuan Pham <hoang.pham@calian.ca>
@hoangphamEclipse hoangphamEclipse mentioned this issue Dec 19, 2022
Merged
hoangphamEclipse added a commit to hoangphamEclipse/timeline-chart that referenced this issue Dec 19, 2022
@hoangphamEclipse
Improve rendering for text labels
38040ae 
Currently, when the timeline chart renders text labels for states, it deletes all
existing labels, then creates new labels, and adds them to the graph. This is not
efficient and makes rendering of the labels sluggish when zooming in and out of the
graph. This commit removes the code that delete the text labels objects on every
re-rerender, and updates the text content of the labels instead of re-creating them.

Fixes eclipse-cdt-cloud#225.

Signed-off-by: Hoang Thuan Pham <hoang.pham@calian.ca>
@hoangphamEclipse hoangphamEclipse self-assigned this Dec 20, 2022
bhufmann pushed a commit that referenced this issue Dec 20, 2022
@hoangphamEclipse @bhufmann
Improve rendering for text labels
266fb6b 
Currently, when the timeline chart renders text labels for states, it deletes all
existing labels, then creates new labels, and adds them to the graph. This is not
efficient and makes rendering of the labels sluggish when zooming in and out of the
graph. This commit removes the code that delete the text labels objects on every
re-rerender, and updates the text content of the labels instead of re-creating them.

Fixes #225.

Signed-off-by: Hoang Thuan Pham <hoang.pham@calian.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoangphamEclipse hoangphamEclipse

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve rendering for text labels hoangphamEclipse/timeline-chart
2 participants
@bhufmann @hoangphamEclipse