Improve rendering for text labels #226
Conversation
Currently, when the timeline chart renders text labels for states, it deletes all existing labels, then creates new labels, and adds them to the graph. This is not efficient and makes rendering of the labels sluggish when zooming in and out of the graph. This commit removes the code that delete the text labels objects on every re-rerender, and updates the text content of the labels instead of re-creating them. Fixes eclipse-cdt-cloud#225. Signed-off-by: Hoang Thuan Pham <hoang.pham@calian.ca>
hoangphamEclipse
force-pushed
the
text-label
branch
from
9b952a3
to
38040ae
Compare
There was a problem hiding this comment.
Every state has a label, this is a great first step, now can we make every label part of a map in the view. We can look it up at the construction time, knowing our size and text. So "HoangThuanPham" would save labels for "HoangThuanPham", "HoangThuan..." "HoangThua..." "HoangThu..." "HoangTh..." "HoangT..." "Hoang..." etc... then instead of doing a new labelobject at line 76, you make a lookup in the view.
Just a thought for later.
Approved
Interesting suggestion for caching BitmapText objects to avoid costly updating of a single BitmapText. I'll create a issue tracker from this comment and we can pick-up later. |
Currently, when the timeline chart renders text labels for states, it deletes all existing labels, then creates new labels, and adds them to the graph. This is not efficient and makes rendering of the labels sluggish when zooming in and out of the graph. This commit removes the code that delete the text labels objects on every re-render, and updates the text content of the labels instead of re-creating them.
Fixes #225.
Signed-off-by: Hoang Thuan Pham hoang.pham@calian.ca