Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support navigation in time by clicking on the horizontal scrollbar #97

Closed
mirsky-work opened this issue Jan 11, 2021 · 0 comments · Fixed by #181
Closed

Support navigation in time by clicking on the horizontal scrollbar #97

mirsky-work opened this issue Jan 11, 2021 · 0 comments · Fixed by #181
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mirsky-work
Copy link
Contributor

I'd like to be able to quickly navigate to a certain point in time by clicking on the horizontal scrollbar.
click-scrollbar
@mirsky-work mirsky-work added bug Something isn't working good first issue Good for newcomers labels Jan 13, 2021
@ghost ghost self-assigned this Jul 8, 2021
williamsyang-work pushed a commit to williamsyang-work/timeline-chart that referenced this issue Feb 24, 2022
Add transparent background with onClick snapping
dc1098b 
Add to TimeGraphNavigator.  Background has on-click function of snapping
the scrollbar to the clicked position.

Fixes: eclipse-cdt-cloud#97

Signed-off-by: Will Yang <william.yang@ericsson.com>
williamsyang-work added a commit to williamsyang-work/timeline-chart that referenced this issue Feb 25, 2022
@williamsyang-work
Snap to mouse on time-graph-navigator click
deac9cb 
Adds background PIXI rectangless to the time-graph-navigator +
vertical-navigator components.  This rect listens for clicks then
centers the handler on the mouse and resumes 'dragging' for navigating.

Fixes: eclipse-cdt-cloud#97

Signed-off-by: Will Yang <william.yang@ericsson.com>
williamsyang-work pushed a commit to williamsyang-work/timeline-chart that referenced this issue Feb 26, 2022
@williamsyang-work
Snap to mouse on time-graph-navigator click
1a93e81 
Adds background PIXI rectangless to the time-graph-navigator +
vertical-navigator components.  This rect listens for clicks then
centers the handler on the mouse and resumes 'dragging' for navigating.

Fixes: eclipse-cdt-cloud#97

Signed-off-by: Will Yang <william.yang@ericsson.com>

removed console.dir

Snap feature for vertical-scrollbar component

Snap-on-click feature implemented for the vertical scrollbar.

Some modifications added to "mouseup" logic for both horizontal +
vertcal scrollbars.  Handles edge-cases.

Signed-off-by: Will Yang <william.yang@ericsson.com>

Scroll bar resumes drag function after snapping to cursor

This change has the scrollbar resume the ususal drag/move function after snapping to the position clicked on background.

'mousedown' event is also  triggered on mouseover when the 'snapped' flag is true.  Snapped state added to stateController.

'mouseup' and 'mouseupoutside' event handlers switched to global document 'mouseup' because they would not trigger after 'mouseover' event.  'mouseupoutside' only triggered if initial 'mousedown' click was inside the TimeGraphUnitController rect.  Snapping always has initial click outside the rect.

Signed-off-by: Will Yang <william.yang@ericsson.com>

Add transparent background with onClick snapping

Add to TimeGraphNavigator.  Background has on-click function of snapping
the scrollbar to the clicked position.

Fixes: eclipse-cdt-cloud#97

Signed-off-by: Will Yang <william.yang@ericsson.com>
williamsyang-work pushed a commit to williamsyang-work/timeline-chart that referenced this issue Feb 26, 2022
@williamsyang-work
Snap to mouse on time-graph-navigator click
dad5e6b 
Adds background PIXI rectangless to the time-graph-navigator +
vertical-navigator components.  This rect listens for clicks then
centers the handler on the mouse and resumes 'dragging' for navigating.

Fixes: eclipse-cdt-cloud#97

Signed-off-by: Will Yang <william.yang@ericsson.com>
@williamsyang-work williamsyang-work mentioned this issue Feb 28, 2022
Merged
williamsyang-work pushed a commit to williamsyang-work/timeline-chart that referenced this issue Mar 3, 2022
@williamsyang-work
Snap to mouse on time-graph-navigator click
918bdd6 
Adds background PIXI rectangless to the time-graph-navigator +
vertical-navigator components.  This rect listens for clicks then
centers the handler on the mouse and resumes 'dragging' for navigating.

Fixes: eclipse-cdt-cloud#97

Signed-off-by: Will Yang <william.yang@ericsson.com>
williamsyang-work pushed a commit to williamsyang-work/timeline-chart that referenced this issue Mar 3, 2022
@williamsyang-work
Snap to mouse on time-graph-navigator click
5ea994f 
Snap to mouse on time-graph-navigator click

Adds background PIXI rectangles to the time-graph-navigator +
vertical-navigator components.  This rectangle listens for clicks then centers the handler on the mouse and resumes 'dragging' for navigating.

Fixes: eclipse-cdt-cloud#97

Signed-off-by: Will Yang <william.yang@ericsson.com>
williamsyang-work pushed a commit to williamsyang-work/timeline-chart that referenced this issue Mar 3, 2022
@williamsyang-work
Snap to mouse on time-graph-navigator click
c39aae9 
Snap to mouse on time-graph-navigator click

Adds background PIXI rectangles to the time-graph-navigator +
vertical-navigator components.  This rectangle listens for clicks then centers the handler on the mouse and resumes 'dragging' for navigating.

Fixes: eclipse-cdt-cloud#97

Signed-off-by: Will Yang <william.yang@ericsson.com>

hotfix
williamsyang-work pushed a commit to williamsyang-work/timeline-chart that referenced this issue Mar 3, 2022
@williamsyang-work
Snap to mouse on time-graph-navigator click
d018972 
Snap to mouse on time-graph-navigator click

Adds background PIXI rectangles to the time-graph-navigator +
vertical-navigator components.  This rectangle listens for clicks then centers the handler on the mouse and resumes 'dragging' for navigating.

Fixes: eclipse-cdt-cloud#97

Signed-off-by: Will Yang <william.yang@ericsson.com>
williamsyang-work pushed a commit to williamsyang-work/timeline-chart that referenced this issue Mar 3, 2022
@williamsyang-work
Snap to mouse on time-graph-navigator click
63558bf 
Snap to mouse on time-graph-navigator click

Adds background PIXI rectangles to the time-graph-navigator +
vertical-navigator components.  This rectangle listens for clicks then centers the handler on the mouse and resumes 'dragging' for navigating.

Fixes: eclipse-cdt-cloud#97

Signed-off-by: Will Yang <william.yang@ericsson.com>
bhufmann pushed a commit that referenced this issue Mar 7, 2022
@bhufmann
Snap to mouse on time-graph-navigator click
be37b18 
Snap to mouse on time-graph-navigator click

Adds background PIXI rectangles to the time-graph-navigator +
vertical-navigator components.  This rectangle listens for clicks then centers the handler on the mouse and resumes 'dragging' for navigating.

Fixes: #97

Signed-off-by: Will Yang <william.yang@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TimeGraphNavigator snap on click feature williamsyang-work/timeline-chart
1 participant
@mirsky-work