TimeGraphNavigator snap on click feature #181
Conversation
williamsyang-work
changed the title
williamsyang-work
force-pushed
the
scrollbar-snap-on-click-feature
branch
2 times, most recently
from
1a93e81
to
dad5e6b
Compare
| this.stateController.snapped = false | ||
| } | ||
| const moveEnd = () => { | ||
| this.mouseIsDown = false |
There was a problem hiding this comment.
Use 4 space indentation. Comment applies to the whole PR.
Missing ; ?
| this.mouseIsDown = false | ||
| } | ||
| this.addEvent('mouseover', event => { | ||
| if(this.stateController.snapped) moveStart(event) |
There was a problem hiding this comment.
Space after if, use {} block for if-clause (with line break, indentation, ;).
| this.addEvent('mouseupoutside', moveEnd, this._displayObject); | ||
| this.addEvent('mouseup', moveEnd, this._displayObject) | ||
| this.addEvent('mouseupoutside', moveEnd, this._displayObject) | ||
| document.addEventListener('snap-x-end', moveEnd) |
| const start = BIMath.clamp(start0, min, max) | ||
| this.unitController.viewRange = { | ||
| start, | ||
| end: start + this.unitController.viewRangeLength, |
There was a problem hiding this comment.
indentation, unnecessary ,
| } | ||
|
|
||
| protected toggleSnappedState = (bool: boolean) => { | ||
| this.stateController.snapped = bool; |
| } | ||
|
|
||
| render(): void { | ||
| this.rect({ |
| x: 0, | ||
| y: 0 | ||
| }, | ||
| width: Number(this.unitController.viewRangeLength), |
There was a problem hiding this comment.
The viewRangeLength is time in nanoseconds. I assume the width should be equal to the chart width in pixels?
There was a problem hiding this comment.
Yes. This has been changed to stateController.canvasDisplayWidth. Had to change some of the logic because of this (line 129).
| y: 0 | ||
| }, | ||
| width: Number(this.unitController.viewRangeLength), | ||
| color: 0xe100ff, |
There was a problem hiding this comment.
Just curious, color value is irrelevant since opacity is 0, right?
There was a problem hiding this comment.
Yes, can't see color w/ opacity = 0. This was to visually see the background width. Color has been removed.
williamsyang-work
force-pushed
the
scrollbar-snap-on-click-feature
branch
4 times, most recently
from
c39aae9
to
d018972
Compare
Snap to mouse on time-graph-navigator click Adds background PIXI rectangles to the time-graph-navigator + vertical-navigator components. This rectangle listens for clicks then centers the handler on the mouse and resumes 'dragging' for navigating. Fixes: eclipse-cdt-cloud#97 Signed-off-by: Will Yang <william.yang@ericsson.com>
williamsyang-work
force-pushed
the
scrollbar-snap-on-click-feature
branch
from
d018972
to
63558bf
Compare
|
@PatrickTasse I fixed the indentation, semicolons, and unnecessary commas in both files. I addressed the unique issues in replies to their comments! |
TimeGraphNavigator and TimeGraphVerticalScrollbar Snap On Click Feature
Adds background PIXI rectangles to the time-graph-navigator + vertical-scrollbar components. This rectangle listens for clicks then centers the handler on the mouse and resumes 'dragging' for navigating.
Fixes: #97
Signed-off-by: Will Yang william.yang@ericsson.com