Use @devfile/api types in the dashboard frontend #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
reviewed
Sep 1, 2021
packages/dashboard-frontend/src/pages/GetStarted/updateDevfileMetadata.ts
Outdated
Show resolved
Hide resolved
sleshchenko
reviewed
Sep 1, 2021
packages/dashboard-frontend/src/pages/WorkspaceDetails/Header/Actions/index.tsx
Outdated
Show resolved
Hide resolved
sleshchenko
reviewed
Sep 1, 2021
sleshchenko
reviewed
Sep 1, 2021
packages/dashboard-frontend/src/services/helpers/getErrorMessage.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/services/workspace-client/devworkspace/devWorkspaceClient.ts
Outdated
Show resolved
Hide resolved
sleshchenko
reviewed
Sep 2, 2021
packages/dashboard-backend/src/services/kubeclient/helpers/index.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/containers/FactoryLoader/index.tsx
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/containers/FactoryLoader/updateDevfileMetadata.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/services/devfileApi/typeguards.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/services/workspace-client/devworkspace/converters/index.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-backend/src/devworkspace-client/services/api/che-api.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/store/Workspaces/devWorkspaces/index.ts
Outdated
Show resolved
Hide resolved
olexii4
reviewed
Sep 3, 2021
olexii4
reviewed
Sep 3, 2021
packages/dashboard-frontend/src/store/__mocks__/devWorkspaceBuilder.ts
Outdated
Show resolved
Hide resolved
olexii4
reviewed
Sep 3, 2021
akurinnoy
force-pushed
the
use-devfile-api
branch
from
ff12894
to
fda8e7c
Compare
sleshchenko
reviewed
Sep 8, 2021
olexii4
reviewed
Sep 8, 2021
packages/dashboard-frontend/src/store/__mocks__/devWorkspaceBuilder.ts
Outdated
Show resolved
Hide resolved
olexii4
reviewed
Sep 8, 2021
olexii4
reviewed
Sep 8, 2021
* fix: fix getter for error messages Signed-off-by: Oleksii Orel <oorel@redhat.com>
|
Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-329 |
sleshchenko
approved these changes
Sep 10, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4, sleshchenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR refactors the Dashboard Frontend to use types from
@devfile/apipackage. It extends original interfaces provided to have some optional fields mandatory and applies them to the dashboard frontend.What issues does this PR fix or reference?
fixes eclipse-che/che#20191