Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop 'state', 'session' and 'code' attributes during startup #744

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Mar 2, 2023

What does this PR do?

Drop 'session' and 'code' attributes during startup.

What issues does this PR fix or reference?

fixes eclipse-che/che#21655

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 requested a review from ibuziuk March 2, 2023 01:57
@olexii4 olexii4 requested a review from akurinnoy as a code owner March 2, 2023 01:57
@che-bot
Copy link
Contributor

che-bot commented Mar 2, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-744

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #744 (4208f59) into main (f803205) will increase coverage by 0.00%.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##             main     #744   +/-   ##
=======================================
  Coverage   77.64%   77.64%           
=======================================
  Files         320      320           
  Lines       31193    31198    +5     
  Branches     1840     1840           
=======================================
+ Hits        24219    24224    +5     
  Misses       6924     6924           
  Partials       50       50           
Flag Coverage Δ
unittests 77.64% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/GetStarted/GetStartedTab/ImportFromGit/index.tsx 95.95% <33.33%> (+0.04%) ⬆️
packages/dashboard-frontend/src/preload/index.ts 83.72% <100.00%> (+0.19%) ⬆️
...ashboard-frontend/src/services/helpers/location.ts 96.80% <100.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openshift-ci
Copy link

openshift-ci bot commented Mar 2, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit d6385a3 into main Mar 2, 2023
@olexii4 olexii4 deleted the CHE-21655_1 branch March 2, 2023 11:06
@devstudio-release
Copy link

Build 3.6 :: dashboard_3.x/204: Console, Changes, Git Data

@devstudio-release
Copy link

@che-bot che-bot added this to the 7.62 milestone Mar 2, 2023
@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.6 :: update-digests_3.x/2369: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: push-latest-container-to-quay_3.x/1874: SUCCESS

Copied: dashboard-rhel8; /job/DS_CI/job/update-digests_3.x triggered;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.13 v4.12 v4.11 v4.10

@devstudio-release
Copy link

Build 3.6 :: copyIIBsToQuay/1104: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.6 :: sync-to-downstream_3.x/2595: SUCCESS

Build container: devspaces-dashboard synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2467 triggered;

@devstudio-release
Copy link

Build 3.6 :: dashboard_3.x/204: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2595 triggered

@devstudio-release
Copy link

Build 3.6 :: operator-bundle_3.x/982: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.6 :: copyIIBsToQuay/1105: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: push-latest-container-to-quay_3.x/1875: SUCCESS

Copied: devspaces-operator-bundle; bundle-generated updated;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.13 v4.12 v4.11 v4.10

@devstudio-release
Copy link

Build 3.6 :: copyIIBsToQuay/1104: SUCCESS

3.6
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.6-82
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.19-4
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-445402-440885-s390x
  + quay.io/devspaces/iib:3.6-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.6-v4.12-445401-440880-s390x
  + quay.io/devspaces/iib:3.6-v4.11-445400-440871-s390x
  + quay.io/devspaces/iib:3.6-v4.10-445399-440866-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-445402-440885-ppc64le
  + quay.io/devspaces/iib:3.6-v4.12-445401-440880-ppc64le
  + quay.io/devspaces/iib:3.6-v4.11-445400-440871-ppc64le
  + quay.io/devspaces/iib:3.6-v4.10-445399-440866-ppc64le
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.6-83
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-445402-440885-x86_64
  + quay.io/devspaces/iib:3.6-v4.12-445401-440880-x86_64
  + quay.io/devspaces/iib:3.6-v4.11-445400-440871-x86_64
  + quay.io/devspaces/iib:3.6-v4.10-445399-440866-x86_64

@devstudio-release
Copy link

Build 3.6 :: sync-to-downstream_3.x/2596: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2468 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.6 :: operator-bundle_3.x/982: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2596 triggered

@devstudio-release
Copy link

Build 3.6 :: dsc_3.x/688: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: update-digests_3.x/2369: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/982 triggered

@devstudio-release
Copy link

Build 3.6 :: dsc_3.x/688: SUCCESS

3.6.0 CI

@devstudio-release
Copy link

Build 3.6 :: copyIIBsToQuay/1105: SUCCESS

3.6
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.6-83
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.19-4
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-445402-440885-ppc64le
  + quay.io/devspaces/iib:3.6-v4.12-445401-440880-ppc64le
  + quay.io/devspaces/iib:3.6-v4.11-445422-440871-ppc64le
  + quay.io/devspaces/iib:3.6-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
  + quay.io/devspaces/iib:3.6-v4.10-445420-440866-ppc64le
  + quay.io/devspaces/iib:3.6-v4.10-ppc64le
  + quay.io/devspaces/iib:next-v4.10-ppc64le
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-445402-440885-x86_64
  + quay.io/devspaces/iib:3.6-v4.12-445423-440880-x86_64
  + quay.io/devspaces/iib:3.6-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.6-v4.11-445422-440871-x86_64
  + quay.io/devspaces/iib:3.6-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
  + quay.io/devspaces/iib:3.6-v4.10-445420-440866-x86_64
  + quay.io/devspaces/iib:3.6-v4.10-x86_64
  + quay.io/devspaces/iib:next-v4.10-x86_64
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-445429-440885-s390x
  + quay.io/devspaces/iib:3.6-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.6-v4.12-445423-440880-s390x
  + quay.io/devspaces/iib:3.6-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.6-v4.11-445422-440871-s390x
  + quay.io/devspaces/iib:3.6-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
  + quay.io/devspaces/iib:3.6-v4.10-445420-440866-s390x
  + quay.io/devspaces/iib:3.6-v4.10-s390x
  + quay.io/devspaces/iib:next-v4.10-s390x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants