docs: Drop single user support #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skabashnyuk
requested review from
MichalMaler,
rkratky,
themr0c and
a team
as code owners
|
Try the PR on Eclipse Che hosted by Red Hat |
|
What is the target version? |
|
2.12. if that is problematic it could be postponed to 2.13 |
themr0c
reviewed
Aug 30, 2021
modules/administration-guide/partials/con_authentication-modes.adoc
Outdated
Show resolved
Hide resolved
themr0c
reviewed
Aug 30, 2021
modules/administration-guide/partials/con_che-workspace-controller.adoc
Outdated
Show resolved
Hide resolved
themr0c
reviewed
Aug 30, 2021
modules/administration-guide/partials/con_che-workspace-controller.adoc
Outdated
Show resolved
Hide resolved
themr0c
reviewed
Aug 30, 2021
modules/installation-guide/partials/assembly_installing-che.adoc
Outdated
Show resolved
Hide resolved
themr0c
reviewed
Aug 30, 2021
modules/installation-guide/partials/assembly_installing-che.adoc
Outdated
Show resolved
Hide resolved
themr0c
reviewed
Aug 30, 2021
modules/installation-guide/partials/con_security-considerations.adoc
Outdated
Show resolved
Hide resolved
|
I left some suggestions @skabashnyuk. We don't need to document previous behavior, and we can remove the lists when there is no more choice to make. |
….adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
…ller.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
…ller.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
…s.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
themr0c
approved these changes
Sep 1, 2021
There was a problem hiding this comment.
Removed more occurrences of single-user, and multiuser as an option.
Tested successfully on https://workspaces.openshift.com/#https://github.com/skabashnyuk/che-docs/tree/singleuser
Not tested the procedures where I removed --multiuser, but I believe this option is obsolete for a long time.
themr0c
reviewed
Sep 2, 2021
modules/administration-guide/partials/con_che-workspace-controller.adoc
Outdated
Show resolved
Hide resolved
nickboldt
reviewed
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
Drop single user support
What issues does this pull request fix or reference?
eclipse-che/che#20295
eclipse-che/che#20314
eclipse-che/che-server#89
Specify the version of the product this pull request applies to
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.