Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop single user support on Che Server #89

Merged
merged 9 commits into from
Sep 9, 2021

Conversation

xbaran4
Copy link
Contributor

@xbaran4 xbaran4 commented Aug 20, 2021

What does this PR do?

Removes checking for single-user mode
Removes classes and modules used only in single-user mode
Removes H2 dependecies

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Implements eclipse-che/che#20314

How to test this PR?

Che server would go into single-user mode when installed with helm.
Installation with helm is now deprecated eclipse-che/che#20183
With this PR, che server now goes straight into multiuser mode and is therefore dependent on postgreSQL and id provider and will crash on helm installation.
So, to test the multiuser mode I deployed che on openshift with patch

spec:
  server:
    cheImage: quay.io/pbaran/che-server
    cheImagePullPolicy: Always
    cheImageTag: singleuser

and created a workspace.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: xbaran4 <pbaran@redhat.com>
Signed-off-by: xbaran4 <pbaran@redhat.com>
Signed-off-by: xbaran4 <pbaran@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2021

Can one of the admins verify this patch?

Copy link
Contributor

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, deleting that much code must have felt great :) Good job!

@skabashnyuk skabashnyuk merged commit cead406 into eclipse-che:main Sep 9, 2021
@che-bot che-bot added this to the 7.37 milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants