-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop single user support on Che Server #89
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xbaran4 <pbaran@redhat.com>
Signed-off-by: xbaran4 <pbaran@redhat.com>
Signed-off-by: xbaran4 <pbaran@redhat.com>
Can one of the admins verify this patch? |
Signed-off-by: xbaran4 <pbaran@redhat.com>
Signed-off-by: xbaran4 <pbaran@redhat.com>
6 tasks
xbaran4
requested review from
yhontyk,
ibuziuk,
MichalMaler,
nickboldt,
skabashnyuk,
sleshchenko and
themr0c
as code owners
September 6, 2021 12:02
skabashnyuk
approved these changes
Sep 7, 2021
metlos
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, deleting that much code must have felt great :) Good job!
sparkoo
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes checking for single-user mode
Removes classes and modules used only in single-user mode
Removes H2 dependecies
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Implements eclipse-che/che#20314
How to test this PR?
Che server would go into single-user mode when installed with helm.
Installation with helm is now deprecated eclipse-che/che#20183
With this PR, che server now goes straight into multiuser mode and is therefore dependent on postgreSQL and id provider and will crash on helm installation.
So, to test the multiuser mode I deployed che on openshift with patch
and created a workspace.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.