-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
procedures: rewrite and expand the "Backup and disaster recovery" sections of the admin guide #2121
Conversation
…-a-file.adoc Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
…-a-file.adoc Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
…-a-file.adoc Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
…-a-file.adoc Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
…-a-file.adoc Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
…-an-variable.adoc Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
...-guide/partials/proc_configuring-che-with-custom-resources-to-use-an-sftp-backup-server.adoc
Outdated
Show resolved
Hide resolved
...-guide/partials/proc_configuring-che-with-custom-resources-to-use-an-sftp-backup-server.adoc
Outdated
Show resolved
Hide resolved
...-guide/partials/proc_configuring-che-with-custom-resources-to-use-an-sftp-backup-server.adoc
Show resolved
Hide resolved
...rtials/proc_configuring-prod-cli-with-environment-variables-to-use-a-rest-backup-server.adoc
Outdated
Show resolved
Hide resolved
...rtials/proc_configuring-prod-cli-with-environment-variables-to-use-a-rest-backup-server.adoc
Outdated
Show resolved
Hide resolved
...tials/proc_configuring-prod-cli-with-environment-variables-to-use-an-sftp-backup-server.adoc
Show resolved
Hide resolved
...tials/proc_configuring-prod-cli-with-environment-variables-to-use-an-sftp-backup-server.adoc
Outdated
Show resolved
Hide resolved
...tials/proc_configuring-prod-cli-with-environment-variables-to-use-an-sftp-backup-server.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/partials/proc_configuring-the-external-postgresql.adoc
Outdated
Show resolved
Hide resolved
...als/proc_restoring-a-che-instance-by-using-prod-cli-and-a-checluserbackup-custom-object.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/partials/con_backup-and-recovery.adoc
Outdated
Show resolved
Hide resolved
|
||
{prod-short} can use the following backup servers that are compatible with the integrated Restic: | ||
|
||
SFTP:: See the documentation for the SFTP server solution you plan to use (link:https://www.openssh.com/[OpenSSH] or a derived commercial product) and the link:https://restic.readthedocs.io/en/latest/030_preparing_a_new_repo.html#sftp[Restic Docs on SFTP]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: I'd like to put it at the end of the list, please, or even better, reverse the order to have rest, s3, sftp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmorhun
I understand that I'm not a typical admin. That said, on another page, we recommend a specific REST server with which I ran into the following issues when I was trying to set it up:
- Neither
restic
norrest server
show any error messages if something in the setup is missing or not as expected. So trying this combination of bothrestic
norrest server
to work together using a remote server turned into frustrating guesswork for me. - The README on https://github.com/restic/rest-server is brief and unclear, and I couldn't find online any third-party explanation about the details of how it should be used correctly (without experimenting to make it work "trial and error"). I believe they need to improve their docs.
- I was setting up the external server from scratch, so I ended up having to research and install some dependencies for the
rest server
that I didn't have to worry about for SFTP.
So I killed a lot of time trying to make the rest server
work on a remote server, and then in contrast I quickly and easily set up an SFTP server. BTW, SFTP also involves an open source solution.
The page on REST servers is full-size in this PR. It's just that I moved it to the third place for users who have no preference and just pick the first option (like I did). If any users prefer to use rest server
, they still have everything we expect to give them in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...ation-guide/partials/assembly_backing-up-of-che-instances-to-the-internal-backup-server.adoc
Outdated
Show resolved
Hide resolved
...ng-up-a-che-instance-to-the-internal-server-by-using-the-checlusterbackup-custom-object.adoc
Outdated
Show resolved
Hide resolved
...ls/assembly_backing-up-a-che-instance-to-a-rest-backup-server-by-using-custom-resources.adoc
Show resolved
Hide resolved
...n-guide/partials/proc_configuring-che-with-custom-resources-to-use-a-rest-backup-server.adoc
Outdated
Show resolved
Hide resolved
...n-guide/partials/proc_configuring-che-with-custom-resources-to-use-a-rest-backup-server.adoc
Outdated
Show resolved
Hide resolved
...ministration-guide/partials/proc_configuring-che-with-custom-resources-to-use-amazon-s3.adoc
Outdated
Show resolved
Hide resolved
|
||
include::snip_warning-backup-snapshots-are-bound-to-specific-cluster.adoc[] | ||
|
||
IMPORTANT: The `CheClusterRestore` custom object is unusable for recovering a {prod-short} instance of an earlier version of {prod-short}. Use `{prod-cli}` to recover a {prod-short} instance of an earlier version of {prod-short}; see xref:restoring-a-che-instance-from-a-backup-by-using-prod-cli_{context}[]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: this is more my fault, but it is still possible if admin manually deletes current and deploy required version of Che and the apply the procedure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmorhun I can fix it. Could you clarify what you want me to change or add in this IMPORTANT admonition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should hightlight that, but just let users know. Preferred way is to use chectl, but just in case, if a user doesn't want to use it for some reason, we can tell about a long way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmorhun, no worries, I've changed it to:
IMPORTANT: Do not use the `CheClusterRestore` custom object
to recover a {prod-short} instance of an earlier version of {prod-short}!
Use only `{prod-cli}` to recover a {prod-short} instance of
an earlier version of {prod-short};
see xref:restoring-a-che-instance-from-a-backup-by-using-prod-cli_{context}[]!
...tials/proc_restoring-a-che-instance-from-a-backup-by-using-the-checlusterrestore-object.adoc
Show resolved
Hide resolved
...als/proc_restoring-a-che-instance-by-using-prod-cli-and-a-checluserbackup-custom-object.adoc
Show resolved
Hide resolved
...als/proc_restoring-a-che-instance-by-using-prod-cli-and-a-checluserbackup-custom-object.adoc
Show resolved
Hide resolved
...dministration-guide/partials/proc_restoring-a-che-instance-from-a-backup-by-snapshot-id.adoc
Show resolved
Hide resolved
...dministration-guide/partials/proc_restoring-a-che-instance-from-a-backup-by-snapshot-id.adoc
Show resolved
Hide resolved
...dministration-guide/partials/proc_restoring-a-che-instance-from-a-backup-by-snapshot-id.adoc
Outdated
Show resolved
Hide resolved
...tials/proc_restoring-a-che-instance-from-a-backup-by-using-the-checlusterrestore-object.adoc
Outdated
Show resolved
Hide resolved
...tials/proc_restoring-a-che-instance-from-a-backup-by-using-the-checlusterrestore-object.adoc
Outdated
Show resolved
Hide resolved
...n-guide/partials/proc_restoring-a-che-instance-from-its-latest-backup-by-using-prod-cli.adoc
Show resolved
Hide resolved
...n-guide/partials/proc_restoring-a-che-instance-from-its-latest-backup-by-using-prod-cli.adoc
Outdated
Show resolved
Hide resolved
...ration-guide/partials/assembly_backing-up-a-che-instance-to-amazon-s3-by-using-prod-cli.adoc
Outdated
Show resolved
Hide resolved
...inistration-guide/partials/assembly_backing-up-of-che-instances-to-a-rest-backup-server.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/partials/assembly_backing-up-of-che-instances-to-amazon-s3.adoc
Outdated
Show resolved
Hide resolved
...nistration-guide/partials/assembly_backing-up-of-che-instances-to-an-sftp-backup-server.adoc
Outdated
Show resolved
Hide resolved
...ng-up-a-che-instance-by-using-prod-cli-and-a-CheBackupServerConfiguration-custom-object.adoc
Show resolved
Hide resolved
...ng-up-a-che-instance-by-using-prod-cli-and-a-CheBackupServerConfiguration-custom-object.adoc
Outdated
Show resolved
Hide resolved
useInternalBackupServer: false <2> | ||
---- | ||
<1> Name of the `CheBackupServerConfiguration` custom object defining what backup server to use. | ||
<2> Configures the custom resource to back up to a backup server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rephrase because it backup to a backup server anyway. The question is between internal backup server managed by Che or a server (internal or external) managed by admin.
nitpick: it configures operator via this CR, not CR itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmorhun, I've changed it to:
<2> Configures the Operator via this custom resource
to use the {prod-short}-managed internal backup server
or an administrator-managed external backup server
(SFTP, Amazon S3 or S3 API compatible storage, or REST).
...proc_backing-up-a-che-instance-to-amazon-s3-by-using-prod-cli-with-command-line-options.adoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please address my remarks
Mykola completed his engineering review. This PR can be (finally!) merged after the following Vale updates that I requested are completed: |
…tions of the admin guide (#2121) Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Michal Maléř <mmaler@redhat.com> Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
What does this pull request change?
https://www.eclipse.org/che/docs/che-7/administration-guide/backup-and-disaster-recovery/
Preview
What issues does this pull request fix or reference?
3268
Specify the version of the product this pull request applies to
7.36
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.