-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vale errors on hostname, TLS, terminal, OS, vscode #145
Labels
bug
Something isn't working
Comments
max-cx
changed the title
vale errors on hostname, TLS, terminal
vale errors on hostname, TLS, terminal, OS, vscode, /
Jan 5, 2022
max-cx
changed the title
vale errors on hostname, TLS, terminal, OS, vscode, /
vale errors on hostname, TLS, terminal, OS, vscode
Jan 5, 2022
Thanks for the report! To work on that, we will have to split into 5 distinct issues. |
Please add point 3. to #114. |
For 2., see #147 |
|
|
For 1.: Indeed, SSG removed the entry for "host name". See: redhat-documentation/supplementary-style-guide#114 |
1., 2., and 3. are done |
Closed
Implemented with #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The following words or expressions trigger illegitimate vale alerts:
1.
We need
hostname
as per IMB Style on p. 292:I suggest downgrading this rule to a warning to avoid massive fixes of
host name
to older docs and to allow for use ofhostname
in new docs.2.
The following screenshot is self-explanatory--the lintered text is
SSL TLS
:How it happened:
At first I had just
TLS
in the text: this was blocked by Vale as an error.So I changed it to
SSL TLS
: 😄 now I got two errors, one forSSL
(Vale doesn't see TLS with it) and one forTLS
(Vale doesn't see SSL with it).In my docs, only TLS is mentioned. If I have to add SSL, that may be technically incorrect:
https://www.internetsociety.org/deploy360/tls/basics/
https://www.ssl.com/faqs/faq-what-is-ssl/
I suggest removing this rule also because SSL and TLS don't seem to be the same thing and in many situations only one of them should be mentioned.
3.
The above rule prevents me from using phrases like "in the terminal window". I can live with having to use
shell prompt
, if I'm forced to do so by Vale, to describe how to enter a command; however, in other situations, like when asking the user to (for example) verify the output of a command in the terminal window, the meaning doesn't work withshell prompt
(or even withcommand line
). So based on my experience,shell prompt
andterminal
are not interchangeable (and by extension alsoterminal window
because then I can't write eventerminal window
as Vale will block it as an error due toterminal
in it).Please also note that IMB Style does not prohibit use of the word
terminal
, as can be seen on p. 347:I suggest downgrading this rule to a warning as explained.
4.
As the screenshot above shows, we cannot always replace
OS
withoperating system
. There are product names that haveOS
in them like macOS andz/OS
as in :https://www.eclipse.org/che/docs/che-7/extensions/eclipse-che4z/ and in eclipse-che/che-docs#2204I suggest downgrading this rule to a warning as explained.
5.
Lower-case
vscode
should be acceptable because of its occurrences in third-party links.I suggest downgrading this rule to a warning as explained.
The text was updated successfully, but these errors were encountered: