-
Notifications
You must be signed in to change notification settings - Fork 26
Add devfile, CONTRIBUTING.md file, set up image build for dev container. #68
Conversation
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
======================================
Coverage 66.6% 66.6%
======================================
Files 6 6
Lines 569 569
======================================
Hits 379 379
Misses 165 165
Partials 25 25 Continue to review full report at Codecov.
|
CONTRIBUTING.md
Outdated
@@ -0,0 +1,93 @@ | |||
### Development flow | |||
|
|||
You can do che-plugin-broker development inside Eclipse CHE workspace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/CHE/Che/g. It's not an acronym, and you shouldn't be SHOUTING. :)
CONTRIBUTING.md
Outdated
To create development Eclipse CHE workspace we provide che-plugin-broker devfile [devfile.yaml](devfile.yaml). | ||
> See more about [devfile](https://redhat-developer.github.io/devfile) | ||
|
||
### Create Eclipse CHE workspace from devfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, it's Eclipse Che, not CHE! Shh. No yelling. :)
Please fix all refs to CHE. Don't want to confuse people with all the acronym possibilities https://www.abbreviations.com/CHE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable other than the comments about CHE vs. Che.
Though I wish the build process for the two brokers produced a single image, instead of having to have two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution @AndrienkoAleksandr! This is very useful.
I've built the image and tested the devfile on Che, and everything is working as expected.
I've added a few optional suggestions below (mostly typos, etc.)
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
2d6dbea
to
518acb2
Compare
I fixed typo, for tasks used |
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
I like your idea and I believe it would make things simpler but I don't think that it can be done really easily in a scope of my issue[1], which goal is to add contribution.md and devfile for developing Plugin Broker in current state. @amisevsk @sleshchenko WDYT? |
Done. eclipse-che/che#14296 Does not block this PR. |
What does this PR do?
Add devfile, CONTRIBUTING.md file, set up image build for dev container.
What issues does this PR fix or reference?
eclipse-che/che#14126
WARNING: DEPENDS ON PR => eclipse-che/che-devfile-registry#79
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com