fix: don't rewrite 127 to 0.0.0.0 (#1051)

Signed-off-by: Michal Vala <mvala@redhat.com>
eclipse-che · Sep 20, 2021 · c7c6702 · c7c6702
1 parent 4d138d5
commit c7c6702
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/tools/build/src/devfile/meta-yaml-to-devfile-yaml.ts b/tools/build/src/devfile/meta-yaml-to-devfile-yaml.ts
@@ -78,10 +78,7 @@ export class MetaYamlToDevfileYaml {
 
     components.unshift(component);
 
-    // replace 127.0.0.1 by 0.0.0.0
-    return components.map(iteratingComponent =>
-      JSON.parse(JSON.stringify(iteratingComponent).replace(/127\.0\.0\.1/g, '0.0.0.0'))
-    );
+    return components;
   }
 
   // eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/explicit-module-boundary-types

diff --git a/tools/build/tests/devfile/meta-yaml-to-devfile-yaml.spec.ts b/tools/build/tests/devfile/meta-yaml-to-devfile-yaml.spec.ts
@@ -44,7 +44,7 @@ describe('Test MetaYamlToDevfileYaml', () => {
     expect(component.name).toBe('che-machine-exec');
     const componentContainer = component.container;
     expect(componentContainer.image).toBe('quay.io/eclipse/che-machine-exec:next');
-    expect(componentContainer.command).toStrictEqual(['/go/bin/che-machine-exec', '--url', '0.0.0.0:4444']);
+    expect(componentContainer.command).toStrictEqual(['/go/bin/che-machine-exec', '--url', '127.0.0.1:4444']);
 
     expect(componentContainer.endpoints).toBeDefined();
     expect(componentContainer.endpoints?.length).toBe(2);
@@ -87,8 +87,7 @@ describe('Test MetaYamlToDevfileYaml', () => {
 
     const theiaHostEnv = theiaIdeComponentContainer.env.find((env: any) => env.name === 'THEIA_HOST');
     expect(theiaHostEnv.name).toBe('THEIA_HOST');
-    // 127.0.0.1 should have been replaced by 0.0.0.0
-    expect(theiaHostEnv.value).toBe('0.0.0.0');
+    expect(theiaHostEnv.value).toBe('127.0.0.1');
 
     expect(theiaIdeComponentContainer.volumeMounts).toBeDefined();
     expect(theiaIdeComponentContainer.volumeMounts?.length).toBe(2);