fix: don't rewrite 127 to 0.0.0.0

[sparkoo]

Signed-off-by: Michal Vala mvala@redhat.com

What does this PR do?

Don't replace 127.0.0.1. It is not secure to listen on all interfaces. After merging eclipse-che/che-operator#1045 it is no longer needed.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#20482

How to test this PR?

image quay.io/mvala/che-plugin-registry:theiaSec

1. deploy che with devworkspaces and plugin-registry ^
2. start a workspace
3. check theia really listens on 127.0.0.1

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[github-actions]

Click here to review and test in web IDE:

[github-actions]

Click here to review and test in web IDE:

[benoitf]

would it be an issue in pure DevWorkspace (where there is no all that gateways ?)

[sparkoo]

would it be an issue in pure DevWorkspace (where there is no all that gateways ?)

yes, Theia won't be reachable then as it will listen on 127.0.0.1 only.

[benoitf]

FYI @sleshchenko standalone DW won't be able anymore to use the devfiles from che plug-in registry

[sleshchenko]

Tested DevWorkspace created with PR's registry and works fine

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benoitf, sleshchenko, sparkoo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[benoitf]

@sleshchenko you're able to open a terminal inside che-theia ? with only DevWorkspace operator ?

[benoitf]

typescript error is not related to this change, safe to merge