Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin registry] remove support for node <... #302

Merged
merged 1 commit into from
Dec 10, 2019
Merged

[plugin registry] remove support for node <... #302

merged 1 commit into from
Dec 10, 2019

Conversation

nickboldt
Copy link
Contributor

[plugin registry] remove support for node < 8 ( #14927 )

Change-Id: I3572d0c9d42996f5048269e2d98a5ec1ac84960c
Signed-off-by: nickboldt nboldt@redhat.com

@nickboldt nickboldt mentioned this pull request Nov 26, 2019
Closed
amisevsk
amisevsk approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with same caveat as in #264

@nickboldt
Copy link
Contributor Author

nickboldt commented Nov 27, 2019 •
edited
Loading

Did not merge in time for 7.5.0 so we have some bandwidth to investigate a deprecation notice / plugin is gone warning for 7.6 via eclipse-che/che#15327

See also eclipse-che/che/issues/14573

@nickboldt
[plugin registry] remove support for node < 8 ( #14927 )
7f36cff 
Change-Id: I3572d0c9d42996f5048269e2d98a5ec1ac84960c
Signed-off-by: nickboldt <nboldt@redhat.com>
@nickboldt nickboldt force-pushed the remove-node-less-than-8-support branch from 8db54e7 to 7f36cff Compare December 10, 2019 18:28
@nickboldt
Copy link
Contributor Author

nickboldt commented Dec 10, 2019 •
edited
Loading

Based on eclipse-che/che#15327 (comment) we can now safely merge this:

  1. We agree that we are going to deprecate plugin X - [plugin registry] Do not reference marketplace.visualstudio.com in plugin registry meta.yaml che#14573 (comment)
  2. We remove any reference to plugin X in the devfile registry => sprint Y - there are no refs to node-debug in the devfile registry in 7.3.x, 7.0.x, or master branch.
  3. We remove the plugin from the plugin-registry => sprint Y+3 - therefore we can remove node-debug from the plugin registry any time after 7.3.x.

@nickboldt nickboldt merged commit d0c2595 into eclipse-che:master Dec 10, 2019
@nickboldt nickboldt mentioned this pull request Dec 10, 2019
Closed
@nickboldt nickboldt mentioned this pull request Feb 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisevsk amisevsk amisevsk approved these changes

@ibuziuk ibuziuk Awaiting requested review from ibuziuk

@l0rd l0rd Awaiting requested review from l0rd

@rhopp rhopp Awaiting requested review from rhopp

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickboldt @amisevsk