Add Che Theia editor endpoint to expose the plugins' webviews on a different origin to make them isolated from Che Theia origin #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fferent origin to make them isolated from Che Theia origin Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
This was referenced Dec 29, 2019
pradeepmalji
suggested changes
Jan 1, 2020
pradeepmalji
reviewed
Jan 1, 2020
| targetPort: 3100 | ||
| attributes: | ||
| protocol: http | ||
| type: ide |
There was a problem hiding this comment.
Type should be webview instead of ide
There was a problem hiding this comment.
See comment: eclipse-che/che#15432 (comment)
There was a problem hiding this comment.
Good catch. Thanks @pradeepmalji!
PR has been updated.
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
AndrienkoAleksandr
approved these changes
Jan 8, 2020
azatsarynnyy
requested review from
amisevsk,
ibuziuk,
l0rd,
nickboldt,
rhopp,
skabashnyuk and
vparfonov
as code owners
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com
What does this PR do?
Adds
webviewsendpoint for Che Theia editor plugin to expose the plugins' webviews on a different origin in order to isolate them from Che Theia origin.This PR is needed for the PR eclipse-che/che-theia#591
Note, this PR depends on plugin unique endpoint feature introduced by the PR eclipse-che/che#15432