Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Che Theia editor endpoint to expose the plugins' webviews on a different origin to make them isolated from Che Theia origin #335

Merged
merged 3 commits into from
Feb 4, 2020
Merged

Add Che Theia editor endpoint to expose the plugins' webviews on a different origin to make them isolated from Che Theia origin #335

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fac48f9
Add Che Theia editor endpoint to expose the plugins' webviews on a di…
azatsarynnyy Dec 28, 2019
2480d43
Fix 'webviews' endpoint type
azatsarynnyy Jan 8, 2020
09ad88c
Merge branch 'master' into az-webviews
azatsarynnyy Feb 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions v3/plugins/eclipse/che-theia/next/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,16 @@ spec:
secure: true
cookiesAuthEnabled: true
discoverable: false
- name: "webviews"
public: true
targetPort: 3100
attributes:
protocol: http
type: ide
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type should be webview instead of ide

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment: eclipse-che/che#15432 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks @pradeepmalji!
PR has been updated.

secure: true
cookiesAuthEnabled: true
discoverable: false
unique: true
- name: "theia-dev"
public: true
targetPort: 3130
Expand Down