Add UDI dockerfiles to update-base-images #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sdawley <sdawley@redhat.com>
nickboldt
approved these changes
Dec 6, 2022
nickboldt
requested changes
Dec 6, 2022
Signed-off-by: sdawley <sdawley@redhat.com>
nickboldt
reviewed
Dec 6, 2022
| @@ -51,6 +52,7 @@ jobs: | |||
| - { repo: "che-incubator/kubernetes-image-puller", user: "CHE_INCUBATOR_BOT_GITHUB_TOKEN", commandFlags: "-maxdepth 3 -f *Dockerfile --pr" } | |||
| - { repo: "che-incubator/kubernetes-image-puller-operator", user: "CHE_INCUBATOR_BOT_GITHUB_TOKEN", commandFlags: "-maxdepth 3 -f *Dockerfile --pr" } | |||
| - { repo: "devfile/devworkspace-operator", user: "CHE_INCUBATOR_BOT_GITHUB_TOKEN", commandFlags: "-maxdepth 3 -f *Dockerfile --pr" } | |||
| - { repo: "devfile/developer-images", user: "CHE_INCUBATOR_BOT_GITHUB_TOKEN", commandFlags: "-maxdepth 3 -f *Dockerfile --pr" } | |||
There was a problem hiding this comment.
this will work if we omit updates for the second dockerfile, https://github.com/devfile/developer-images/pull/46/files#diff-9f21bef4669d474b6ddef409447be53ae91c94cb50b6df9345149a0e89fb5391R3
If we however want to figure out how to keep that one current... then we would need more flags here.
There was a problem hiding this comment.
note also that for this to work the secret has to be pushed to the repo. See step 3 on eclipse-che/che#21575 (just added it tonight). I hope that you have permission to do that step?
nickboldt
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change for eclipse-che/che#21575
Add dockerfiles from https://github.com/devfile/developer-images/ to the update-base-images action.