Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UDI dockerfiles to update-base-images #69

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Add UDI dockerfiles to update-base-images #69

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
426f4e5
Add UDI dockerfiles to update-base-images
SDawley Dec 5, 2022
187bc5f
Second 2/3 of the update
SDawley Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/update-base-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ on:
che-incubator/kubernetes-image-puller,
che-incubator/kubernetes-image-puller-operator,
devfile/devworkspace-operator,
devfile/developer-images,
eclipse-che/che-dashboard,
eclipse-che/che-devfile-registry,
eclipse-che/che-machine-exec,
Expand Down Expand Up @@ -51,6 +52,7 @@ jobs:
- { repo: "che-incubator/kubernetes-image-puller", user: "CHE_INCUBATOR_BOT_GITHUB_TOKEN", commandFlags: "-maxdepth 3 -f *Dockerfile --pr" }
- { repo: "che-incubator/kubernetes-image-puller-operator", user: "CHE_INCUBATOR_BOT_GITHUB_TOKEN", commandFlags: "-maxdepth 3 -f *Dockerfile --pr" }
- { repo: "devfile/devworkspace-operator", user: "CHE_INCUBATOR_BOT_GITHUB_TOKEN", commandFlags: "-maxdepth 3 -f *Dockerfile --pr" }
- { repo: "devfile/developer-images", user: "CHE_INCUBATOR_BOT_GITHUB_TOKEN", commandFlags: "-maxdepth 3 -f *Dockerfile --pr" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will work if we omit updates for the second dockerfile, https://github.com/devfile/developer-images/pull/46/files#diff-9f21bef4669d474b6ddef409447be53ae91c94cb50b6df9345149a0e89fb5391R3

If we however want to figure out how to keep that one current... then we would need more flags here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note also that for this to work the secret has to be pushed to the repo. See step 3 on eclipse-che/che#21575 (just added it tonight). I hope that you have permission to do that step?

- { repo: "eclipse-che/che-dashboard", user: "CHE_BOT_GITHUB_TOKEN", commandFlags: "-maxdepth 3 -f *Dockerfile --pr" }
- { repo: "eclipse-che/che-devfile-registry", user: "CHE_BOT_GITHUB_TOKEN", commandFlags: "-maxdepth 3 -f *Dockerfile --pr" }
- { repo: "eclipse-che/che-machine-exec", user: "CHE_BOT_GITHUB_TOKEN", commandFlags: "-maxdepth 3 -f *Dockerfile --pr" }
Expand All @@ -76,6 +78,7 @@ jobs:
che-incubator/kubernetes-image-puller,
che-incubator/kubernetes-image-puller-operator,
devfile/devworkspace-operator,
devfile/developer-images,
eclipse-che/che-dashboard,
eclipse-che/che-devfile-registry,
eclipse-che/che-machine-exec,
Expand Down