Replace WorkspaceService by DevfileService

[RomanNikitenko]

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

What does this PR do?

Replace WorkspaceService by DevfileService to have multi-root related logic working for DevWorkspace engine.
Also please see the comments

• Enable Che-Theia multi-root mode by default for all workspaces #1053 (comment)
• Replace WorkspaceService by DevfileService #1055 (comment)

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Related to:

• multi-root workspaces should be default when using Dev Workspaces / devfile v2 che#19191
• Enable Che-Theia multi-root mode by default for all workspaces che#19389

How to test this PR?

devfile_V2 use case -DevWorkspace: a workspace should start in Multi-root mode by default.

devfile_V1 use case:

1. Start a workspace and check that the workspace has started in Multi-root mode by default.
2. Add the following to your devfile:

attributes:
  multiRoot: 'off'

3. Start the workspace and check that the Multi-root mode is off.

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

[RomanNikitenko]

I tried to test the changes for DevWorkspace, but faced with the error:

error: error validating "flattened_theia-next.yaml": error validating data: ValidationError(DevWorkspace.metadata): unknown field "attributes" in io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta; if you choose to ignore these errors, turn validation off with --validate=false

Does metadata supports attributes?

My flattened yaml file starts like:

kind: DevWorkspace
apiVersion: workspace.devfile.io/v1alpha2
metadata:
  name: theia
  attributes:
    multiRoot: 'off'
spec:
  started: true
  template:
    projects:

@benoitf could you take a look?

[codecov-io]

Codecov Report

Merging #1055 (46a079c) into master (eeb4526) will increase coverage by 0.74%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##           master    #1055      +/-   ##
==========================================
+ Coverage   29.45%   30.20%   +0.74%     
==========================================
  Files         277      277              
  Lines        9336     9366      +30     
  Branches     1380     1390      +10     
==========================================
+ Hits         2750     2829      +79     
+ Misses       6487     6439      -48     
+ Partials       99       98       -1     

Impacted Files	Coverage Δ
...che-theia-remote-api/src/common/devfile-service.ts	0.00% <ø> (ø)
...e-theia-workspace/src/node/che-workspace-server.ts	0.00% <0.00%> (ø)
...workspace-plugin/src/workspace-projects-manager.ts	0.00% <0.00%> (ø)
...che-server/src/node/che-server-k8s-service-impl.ts	39.13% <50.00%> (+39.13%)	⬆️
...server/src/node/che-server-devfile-service-impl.ts	86.56% <95.00%> (+4.79%)	⬆️
...s-provider-extension/src/browser/prefs-provider.ts	95.74% <100.00%> (+3.63%)	⬆️
...mote-impl-k8s/src/node/k8s-devfile-service-impl.ts	84.61% <100.00%> (+0.61%)	⬆️
...rver/src/node/che-server-workspace-service-impl.ts	37.50% <0.00%> (+37.50%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6429b29...46a079c. Read the comment docs.

[benoitf]

@RomanNikitenko for now it's not but your PR is ok
(DevFile supports it but not the DevWorkspaceTemplate but it'll be changed to global attributes, etc)

As long as we're using DevfileService to get the devfile it's better

[benoitf]

cf devfile/api#239

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job console

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1055
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1055

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

[RomanNikitenko]

@RomanNikitenko for now it's not but your PR is ok
(DevFile supports it but not the DevWorkspaceTemplate but it'll be changed to global attributes, etc)

As long as we're using DevfileService to get the devfile it's better

I see, thanks!

[RomanNikitenko]

[crw-ci-test]

[che-bot]

✅ E2E Happy path tests succeed 🎉

See Details

• Jenkins job console

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1055
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1055

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.