Consume VS Code built-in extensions in Che-Theia #618

vzhukovs · 2020-01-31T14:23:59Z

What does this PR do?

This changes proposal include in che-theia image default VS Code built-in extensions that provide by theia build.

To check this PR, you can use following devfile:

When workspace will start, you'll be able to open View - Open View... - Plugins to ensure that all VS Code built-in extensions are included into assembly.

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

What issues does this PR fix or reference?

eclipse-che/che#14759

Release Notes

Consume VS Code built-in extensions in Che-Theia

Docs PR

N/A - internal enhancement

vzhukovs · 2020-01-31T14:51:57Z

crw-ci-test

benoitf · 2020-01-31T15:54:08Z

generator/src/foreach_yarn

@@ -45,3 +49,14 @@ function mkdirSyncRecursive(dir) {
        curPath.length > 0 && !fs.existsSync(curPath) ? fs.mkdirSync(curPath) : null;
    }
 };
+
+function copyFolderSync(from, to) {


hello, is it fast to copy all the plugins ?

You mean, in comparison with calling system cp -r ?

yes sorry I didn't write much comment

yes comparing this nodejs copy vs system cp

Haven't checked yet. I can try to compare these two approach.

Comparison provided in: #618 (comment)

benoitf

I would wait until monday to merge if possible

benoitf

I think we're copying too many extensions

for example vscode-builtin-typescript-language-features (typescript language server is only added if a sidecar/different plug-in is added no ) ?

Also what about git ? shouldn't it be part of the built-in extensions instead of being copied from Dockerfile ?

https://github.com/theia-ide/vscode-builtin-extensions/releases/tag/v1.39.1-prel

azatsarynnyy · 2020-02-02T22:31:26Z

If I understand everything right, we should not just copy the set of all the VS Code extensions that Theia includes.
But we need to have our own set of VS Code extensions that we want to include in Che Theia.
@benoitf WDYT?

If that's correct, we can just reuse the mechanism provided by Theia:

in Che Theia assembly add theiaPlugins field like in Theia's package.json
use download:plugins script to fetch all the specified extensions

benoitf · 2020-02-03T08:07:52Z

@azatsarynnyy maybe that yes if we're depending on a custom set of extensions it'll be easier

It's mainly because we decided to move some extensions to other containers
about your proposal we may check if it'll download the extensions everytime or if there is cache on downloads as well.

Also probably we need to remove https://github.com/eclipse/che-theia/blob/master/dockerfiles/theia/Dockerfile#L99 and use it from https://github.com/theia-ide/vscode-builtin-extensions/releases as well (through package.json theiaPlugins

vzhukovs · 2020-02-04T15:21:45Z

@benoitf we need to take into account, that if we use download:plugins command in our package.json, we should also rely on specific url for the every extension. Which may be updated in upstream. I think, we should have somewhere the list of name extensions, which we agreed to use with che-theia and copy them from theia package.

vzhukovs · 2020-02-07T18:26:03Z

crw-ci-test

vzhukovs · 2020-02-10T11:30:06Z

@benoitf I compared two ways of copying the directories:

called command to measure the execution time and copied 46 extensions:
time ./foreach_yarn

nodejs copy with function:

function copyFolderSync(from, to) {
    fs.mkdirSync(to);
    fs.readdirSync(from).forEach(element => {
        if (fs.lstatSync(path.join(from, element)).isFile()) {
            fs.copyFileSync(path.join(from, element), path.join(to, element));
        } else {
            copyFolderSync(path.join(from, element), path.join(to, element));
        }
    });
}

./foreach_yarn 0.12s user 0.17s system 55% cpu 0.524 total
./foreach_yarn 0.13s user 0.18s system 79% cpu 0.389 total

system copy with the function:

        const r = spawnSync('cp', ['-R', `${pluginFolderPath}`, `${targetDir}/${pluginFolderName}`], {
            cwd: undefined,
            detached: true,
            stdio: "inherit"
        });
        if (r.status === 1) {
            console.log('this one');
            process.exit(1);
        }

./foreach_yarn 0.14s user 0.32s system 81% cpu 0.555 total
./foreach_yarn 0.13s user 0.28s system 84% cpu 0.492 total

So, copying using nodejs a bit faster, as it doesn't creates additional process.

generator/src/templates/theiaPlugins.json

vzhukovs · 2020-02-11T15:36:25Z

crw-ci-test

che-bot · 2020-02-11T18:02:04Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:618
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:618

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2020-02-12T13:44:47Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:618
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:618

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2020-02-12T13:48:25Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:618
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:618

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2020-02-12T14:48:20Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:618
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:618

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

azatsarynnyy · 2020-02-12T17:02:34Z

generator/src/templates/theiaPlugins.json

+    "vscode-builtin-shellscript": "https://github.com/theia-ide/vscode-builtin-extensions/releases/download/v1.39.1-prel/shellscript-1.39.1-prel.vsix",
+    "vscode-builtin-sql": "https://github.com/theia-ide/vscode-builtin-extensions/releases/download/v1.39.1-prel/sql-1.39.1-prel.vsix",
+    "vscode-builtin-swift": "https://github.com/theia-ide/vscode-builtin-extensions/releases/download/v1.39.1-prel/swift-1.39.1-prel.vsix",
+    "vscode-builtin-typescript": "https://github.com/theia-ide/vscode-builtin-extensions/releases/download/v1.39.1-prel/typescript-1.39.1-prel.vsix",


I guess typescript extension can be removed as we're providing Che Plugin instead

I've tested the updated image and there's no syntax highlighting for TS.

As I understand, there're two builtin extensions in VS Code: typescript-basics and typescript-language-features.
What we provide with TS Che Plugin it's typescript-language-features. And typescript-basics must be bundled with Che Theia.
So, let's revert the removed one - vscode-builtin-typescript. Sorry for the confusion.

che-bot · 2020-02-12T19:11:57Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:618
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:618

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2020-02-13T08:51:00Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:618
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:618

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

benoitf

tested on che.openshift.io

vzhukovs · 2020-02-13T09:59:35Z

crw-ci-test

che-bot · 2020-02-13T10:19:09Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:618
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:618

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

vzhukovs · 2020-02-13T13:27:57Z

crw-ci-test

che-bot · 2020-02-13T13:49:28Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:618
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:618

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2020-02-13T14:32:54Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:618
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:618

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

vzhukovs · 2020-02-13T14:36:28Z

crw-ci-test

che-bot · 2020-02-13T14:52:36Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:618
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:618

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

che-bot · 2020-02-13T15:01:45Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:618
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:618

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

vzhukovs · 2020-02-13T15:04:18Z

crw-ci-test

RomanNikitenko · 2020-02-13T15:05:48Z

@vzhukovskii
I see that you are restarting the tests, but maybe at the moment it's expected that the tests failed
eclipse-che/che#16017

vzhukovs · 2020-02-13T15:07:48Z

@RomanNikitenko the latest run was unstable, error message found in logs:

17:01:36 @eclipse-che/theia-generator:   ● Test Extensions › use default extensions
17:01:36 @eclipse-che/theia-generator:     Unable to execute the command git clone -b master --single-branch --depth 1 https://github.com/eclipse/che-theia che-theia: Error: Command failed: git clone -b master --single-branch --depth 1 https://github.com/eclipse/che-theia che-theia
17:01:36 @eclipse-che/theia-generator:     fatal: Not a git repository: '/tmp/tmpExtensions13845Z4NR05zaBxQz/che-theia/che-theia/.git'
17:01:36 @eclipse-che/theia-generator:       at cp.exec (src/command.ts:939:20)

che-bot · 2020-02-13T15:25:42Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:618
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:618

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2020-02-13T15:28:38Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:618
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:618

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2020-02-13T15:37:00Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:618
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:618

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

vzhukovs · 2020-02-14T08:39:28Z

crw-ci-test

che-bot · 2020-02-14T09:13:23Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:618
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:618

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

eclipse-che deleted a comment from che-bot Jan 31, 2020

vzhukovs changed the title ~~Working copy~~ Consume VS Code built-in extensions in Che-Theia Jan 31, 2020

vzhukovs self-assigned this Jan 31, 2020

vzhukovs added kind/enhancement New feature or request severity/P1 labels Jan 31, 2020

vzhukovs force-pushed the vscode_plugins branch from 15f1672 to 3224b55 Compare January 31, 2020 15:37

vzhukovs marked this pull request as ready for review January 31, 2020 15:37

vzhukovs requested review from azatsarynnyy, benoitf and RomanNikitenko as code owners January 31, 2020 15:37

benoitf reviewed Jan 31, 2020

View reviewed changes

benoitf approved these changes Jan 31, 2020

View reviewed changes

benoitf suggested changes Feb 2, 2020

View reviewed changes

eclipse-che deleted a comment from che-bot Feb 5, 2020

eclipse-che deleted a comment from che-bot Feb 7, 2020

eclipse-che deleted a comment from che-bot Feb 9, 2020

benoitf reviewed Feb 11, 2020

View reviewed changes

generator/src/templates/theiaPlugins.json Outdated Show resolved Hide resolved

eclipse-che deleted a comment from che-bot Feb 12, 2020

azatsarynnyy reviewed Feb 12, 2020

View reviewed changes

benoitf approved these changes Feb 13, 2020

View reviewed changes

azatsarynnyy approved these changes Feb 13, 2020

View reviewed changes

Consume VS Code built-in extension

c75d401

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

vzhukovs force-pushed the vscode_plugins branch from d4ba87d to c75d401 Compare February 13, 2020 14:56

vzhukovs merged commit 7967aa2 into master Feb 14, 2020

vzhukovs deleted the vscode_plugins branch February 14, 2020 09:14

RomanNikitenko mentioned this pull request Feb 19, 2020

Allow to use VS Code builtin extensions in che-theia #572

Closed

azatsarynnyy mentioned this pull request Feb 19, 2020

Add YAML syntaxcoloration by default eclipse-che/che#13187

Closed

Consume VS Code built-in extensions in Che-Theia #618

Consume VS Code built-in extensions in Che-Theia #618

Conversation

vzhukovs commented Jan 31, 2020 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

vzhukovs commented Jan 31, 2020

benoitf Jan 31, 2020

Choose a reason for hiding this comment

vzhukovs Jan 31, 2020

Choose a reason for hiding this comment

benoitf Jan 31, 2020

Choose a reason for hiding this comment

vzhukovs Jan 31, 2020

Choose a reason for hiding this comment

vzhukovs Feb 10, 2020

Choose a reason for hiding this comment

benoitf left a comment

Choose a reason for hiding this comment

benoitf left a comment

Choose a reason for hiding this comment

azatsarynnyy commented Feb 2, 2020

benoitf commented Feb 3, 2020

vzhukovs commented Feb 4, 2020

vzhukovs commented Feb 7, 2020

vzhukovs commented Feb 10, 2020

vzhukovs commented Feb 11, 2020

che-bot commented Feb 11, 2020

che-bot commented Feb 12, 2020

che-bot commented Feb 12, 2020

che-bot commented Feb 12, 2020

azatsarynnyy Feb 12, 2020

Choose a reason for hiding this comment

vzhukovs Feb 12, 2020 • edited Loading

Choose a reason for hiding this comment

azatsarynnyy Feb 12, 2020

Choose a reason for hiding this comment

che-bot commented Feb 12, 2020

che-bot commented Feb 13, 2020

benoitf left a comment

Choose a reason for hiding this comment

vzhukovs commented Feb 13, 2020

che-bot commented Feb 13, 2020

vzhukovs commented Feb 13, 2020

che-bot commented Feb 13, 2020

che-bot commented Feb 13, 2020

vzhukovs commented Feb 13, 2020

che-bot commented Feb 13, 2020

che-bot commented Feb 13, 2020

vzhukovs commented Feb 13, 2020

RomanNikitenko commented Feb 13, 2020

vzhukovs commented Feb 13, 2020

che-bot commented Feb 13, 2020

che-bot commented Feb 13, 2020

che-bot commented Feb 13, 2020

vzhukovs commented Feb 14, 2020

che-bot commented Feb 14, 2020

vzhukovs commented Jan 31, 2020 •

edited

Loading

vzhukovs Feb 12, 2020 •

edited

Loading