Add YAML syntaxcoloration by default

[slemeur]

Description

The IDE should be getting the YAML syntax coloration by default.

Reproduction Steps

OS and version:

Diagnostics:

[benoitf]

All these VS Code extensions should be integrated by default: https://github.com/Microsoft/vscode/tree/master/extensions

[tsmaeder]

@slemeur Marc Dumais is holding off on a CQ for the extensions @benoitf mentions because we haven't told him how we want to handle the case of the LGPL code in the git extension. We could get the rest merged soon if we can exclude that one.

[slemeur]

any update on this?

[tsmaeder]

No, I'm not sure where we could consume those extensions from. Someone needs to find out.

[sunix]

could we just add our yaml extension by default to che-theia ?
What is the problem ?

[slemeur]

why do you need the extension in order to just get syntax coloration?

…

On Thu, Oct 17, 2019 at 4:24 PM Sun Seng David TAN ***@***.***> wrote: could we just add our yaml extenshttps:// github.com/eclipse/che-plugin-registry/tree/master/v3/plugins/redhat/vscode-yamlion by default to che-theia ? What is the problem ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13187>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMPTILMKMJE4Z6FDGTBQMDQPBYTNANCNFSM4HG5VLQQ> .

-- Stévan LeMeur // Product Manager // Developer Tools // +336-87-11-27-55

[benoitf]

I think it may related to #14759

We should provide by default (in che-theia) all 'builtin VS Code extensions' that provides syntax highlights/grammars
It includes https://github.com/microsoft/vscode/tree/master/extensions/yaml

We don't need https://github.com/eclipse/che-plugin-registry/tree/master/v3/plugins/redhat/vscode-yaml for syntax highlights (no language server is required just for syntax highlight)

[benoitf]

No, I'm not sure where we could consume those extensions from. Someone needs to find out.

it can be done like https://github.com/che-incubator/ms-code.typescript/releases as it extracts https://github.com/microsoft/vscode/tree/master/extensions/typescript-language-features

[sunix]

@slemeur to me it would solve several problems at the same time and it would be simple to do:

1. simplify few dependency problems with other extensions like the kubernetes ext. user won't have to think about what to activate. until we figure out a better way to do.
2. it is simple to do: just add the ext in the che-theia default plugin to use.
3. in the future we may need to edit devfile.yaml file in any workspaces. it makes sence to have it by default.
4. we would get syntax highliting for yaml ...

[sunix]

@evidolob told me that the way we get dependencies will change in the next che version. So maybe forget my previous comment.

[tsmaeder]

@benoitf It would make sense to share the build and publish effort in the Theia community. At least the build scripts, etc. should be shared if not publishing the extensions once and consuming them from a common place.

[benoitf]

@tsmaeder AFAIK theia community is already publishing them on npmjs
https://www.npmjs.com/search?q=%40theia%20builtin

[azatsarynnyy]

Fixed by eclipse-che/che-theia#618
VS Code YAML built-in extension is included in Che Theia by default.