-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eslint to Typescript language support plugins #14070
Comments
Since there is no vsix in the release, we need to host the file somewhere (in redhat-developer or so). |
Turns out this one is blocked by: Plugins should have ability to spawn processes #15087 |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
/remove-lifecycle stale |
Thank you for working on this issue. |
just a FYI but tslint is deprecated over eslint now |
I've renamed the issue, instead of tslint we will be providing the eslint extension: https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint |
ES Lint is already introduced to built-ins plugin with PR eclipse-che/che-theia#902 |
it should be a built-in extension |
It's a built-in in theia, why remove it in che-theia and make more work for ourselves to have it as a separate plugin? |
I propose to look at it from a bit different perspective 🙂 : |
Fair enough. @vitaliy-guliy, this one is back on your plate. |
ES Lint 2.1.1 was added to Che plugin registry with eclipse-che/che-plugin-registry#687 |
When building theia, there are numerous rules from tslint being enforced, however, even though there is a vs code extensions for tslint, it's not included in our typescript support (https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin)
This leads to many cases where we only find build problems when running the command line build.
We should find a way to offer tslint support for Che.
The text was updated successfully, but these errors were encountered: