Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint to Typescript language support plugins #14070

Closed
tsmaeder opened this issue Jul 30, 2019 · 13 comments
Closed

Add eslint to Typescript language support plugins #14070

tsmaeder opened this issue Jul 30, 2019 · 13 comments
Assignees
Labels
area/languages Issues related to Language extensions or plugins integration. area/plugins kind/enhancement A feature request - must adhere to the feature request template.
Milestone

Comments

@tsmaeder
Copy link
Contributor

When building theia, there are numerous rules from tslint being enforced, however, even though there is a vs code extensions for tslint, it's not included in our typescript support (https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin)
This leads to many cases where we only find build problems when running the command line build.

We should find a way to offer tslint support for Che.

@tsmaeder tsmaeder added the kind/enhancement A feature request - must adhere to the feature request template. label Jul 30, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 31, 2019
@slemeur slemeur added this to the 7.2.0 milestone Jul 31, 2019
@slemeur slemeur added area/languages Issues related to Language extensions or plugins integration. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 31, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@benoitf benoitf removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@tsmaeder tsmaeder mentioned this issue Sep 3, 2019
41 tasks
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Sep 4, 2019

Since there is no vsix in the release, we need to host the file somewhere (in redhat-developer or so).

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Nov 4, 2019

Turns out this one is blocked by: Plugins should have ability to spawn processes #15087

@tsmaeder tsmaeder mentioned this issue Nov 21, 2019
26 tasks
@che-bot
Copy link
Contributor

che-bot commented May 12, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2020
@che-bot che-bot closed this as completed May 20, 2020
@dariodsa
Copy link

/remove-lifecycle stale

@ericwill ericwill removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 28, 2020
@ericwill ericwill reopened this Oct 28, 2020
@ericwill ericwill removed this from the 7.4.0 milestone Oct 28, 2020
@RickJWagner
Copy link
Contributor

RickJWagner commented Oct 28, 2020

Thank you for working on this issue.
I'd like to add a '+1' to the request for TsLint, we are hearing from CRW users that have the same request.

@benoitf
Copy link
Contributor

benoitf commented Oct 28, 2020

just a FYI but tslint is deprecated over eslint now

@ericwill ericwill changed the title Add tslint to Typescript language support plugins Add eslint to Typescript language support plugins Nov 9, 2020
@ericwill
Copy link
Contributor

ericwill commented Nov 9, 2020

I've renamed the issue, instead of tslint we will be providing the eslint extension: https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint

@vitaliy-guliy
Copy link
Contributor

ES Lint is already introduced to built-ins plugin with PR eclipse-che/che-theia#902
To test how it works see eclipse-che/che-plugin-registry#687 (comment)

@benoitf
Copy link
Contributor

benoitf commented Nov 12, 2020

it should be a built-in extension
it needs to be removed by default and added as separate extension

@benoitf benoitf reopened this Nov 12, 2020
@ericwill
Copy link
Contributor

It's a built-in in theia, why remove it in che-theia and make more work for ourselves to have it as a separate plugin?

@azatsarynnyy
Copy link
Member

I propose to look at it from a bit different perspective 🙂 :
why do we need to launch JavaScript linting extension with every Che Workspace no matter what stack it's based on - Java, go, Python, PHP, etc.?

@ericwill
Copy link
Contributor

Fair enough. @vitaliy-guliy, this one is back on your plate.

@vitaliy-guliy
Copy link
Contributor

ES Lint 2.1.1 was added to Che plugin registry with eclipse-che/che-plugin-registry#687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/languages Issues related to Language extensions or plugins integration. area/plugins kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

9 participants