Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Align plugins with Theia upstream #902

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Align plugins with Theia upstream #902

merged 2 commits into from
Nov 4, 2020

Conversation

vitaliy-guliy
Copy link
Contributor

@vitaliy-guliy vitaliy-guliy commented Nov 3, 2020

Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com

What does this PR do?

Updates references to built-in plugin binaries.

Aligned with Theia upstream:

  • vscode/bat/1.44.2
  • vscode/clojure/1.44.2
  • vscode/coffeescript/1.44.2
  • vscode/configuration-editing/1.44.2
  • vscode/cpp/1.44.2
  • vscode/csharp/1.44.2
  • vscode/debug-auto-launch/1.44.2
  • vscode/fsharp/1.44.2
  • vscode/go/1.44.2
  • vscode/groovy/1.44.2
  • vscode/grunt/1.44.2
  • vscode/gulp/1.44.2
  • vscode/handlebars/1.44.2
  • vscode/hlsl/1.44.2
  • vscode/ini/1.44.2
  • vscode/jake/1.44.2
  • vscode/javascript/1.44.2
  • vscode/less/1.44.2
  • vscode/log/1.44.2
  • vscode/lua/1.44.2
  • vscode/make/1.44.2
  • vscode/markdown/1.44.2
  • vscode/merge-conflict/1.44.2
  • vscode/npm/1.44.2
  • vscode/objective-c/1.44.2
  • vscode/perl/1.44.2
  • vscode/powershell/1.44.2
  • vscode/pug/1.44.2
  • vscode/python/1.44.2
  • vscode/r/1.44.2
  • vscode/razor/1.44.2
  • vscode/ruby/1.44.2
  • vscode/rust/1.44.2
  • vscode/scss/1.44.2
  • vscode/shaderlab/1.44.2
  • vscode/shellscript/1.44.2
  • vscode/sql/1.44.2
  • vscode/swift/1.44.2
  • vscode/typescript/1.44.2
  • vscode/vb/1.44.2
  • vscode/xml/1.44.2
  • vscode/yaml/1.44.2
  • vscode/theme-abyss/1.44.2
  • vscode/theme-defaults/1.44.2
  • vscode/theme-kimbie-dark/1.44.2
  • vscode/theme-monokai/1.44.2
  • vscode/theme-monokai-dimmed/1.44.2
  • vscode/theme-quietlight/1.44.2
  • vscode/theme-red/1.44.2
  • vscode/theme-solarized-dark/1.44.2
  • vscode/theme-tomorrow-night-blue/1.44.2

Updated to more fresh version:

Introduced (copied from upstream):

Left unchanged:

  • vscode/css/1.50.1
  • vscode/css-language-features/1.50.1
  • vscode/html/1.50.1
  • vscode/html-language-features/1.50.1
  • vscode/java/1.50.1
  • vscode/json/1.50.1
  • vscode/json-language-features/1.50.1
  • EditorConfig/EditorConfig/0.14.4
  • vscode/git/1.49.3

What issues does this PR fix or reference?

eclipse-che/che#17524
eclipse-che/che#17123

How to test this PR?

Use docker image, built by CI for this PR.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
@che-bot

This comment has been minimized.

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Nov 4, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:902
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:902

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@vitaliy-guliy vitaliy-guliy marked this pull request as ready for review November 4, 2020 10:51
@benoitf
Copy link
Contributor

benoitf commented Nov 4, 2020

Hello, do you have status for VS Code built-in extensions:

  • debug-server-ready
  • extension-editing
  • git-ui
  • github-authentication
  • github
  • image-preview
  • search-result
  • theme-solarized-light

?

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

played with some file extensions and didn't noticed problems
Also it's already used in upstream theia (and it provides only basic stuff)

@vitaliy-guliy
Copy link
Contributor Author

Hello, do you have status for VS Code built-in extensions:

  • debug-server-ready
  • extension-editing
  • git-ui
  • github-authentication
  • github
  • image-preview
  • search-result
  • theme-solarized-light

?

No, I have not. Do we need them? If yes, then let's introduce extension by extension in separate PR's (to be able to review).

@benoitf
Copy link
Contributor

benoitf commented Nov 4, 2020

yes should be separated stuff in any case.

As it's builtin extensions of VS Code, some other extensions may rely on their presence.

for github* it's managed by Ihor but for others, we may check it they work on upstream theia/already have existing issue, etc.

for theme-solarized-light it looks like only a missing copy/paste

@vitaliy-guliy
Copy link
Contributor Author

Issue to add Git* extensions eclipse-che/che#18281
Issue to add debug-server-ready, extension-editing, image-preview, search-result eclipse-che/che#18282
For theme-solarized-light, I will create one-line PR. No issue is needed.

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it a bit on Hosted Che by performing some basic operations. Works as expected. Thanks!

@vitaliy-guliy vitaliy-guliy merged commit def4090 into master Nov 4, 2020
@vitaliy-guliy vitaliy-guliy deleted the default-plugins2 branch November 4, 2020 14:53
monaka pushed a commit to PizzaFactory/che-theia that referenced this pull request Nov 4, 2020
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
monaka pushed a commit to PizzaFactory/che-theia that referenced this pull request Nov 5, 2020
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
monaka pushed a commit to PizzaFactory/che-theia that referenced this pull request Nov 6, 2020
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Dockerfile.*" to default file associations.
4 participants