-
Notifications
You must be signed in to change notification settings - Fork 111
Conversation
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
Hello, do you have status for VS Code built-in extensions:
? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
played with some file extensions and didn't noticed problems
Also it's already used in upstream theia (and it provides only basic stuff)
No, I have not. Do we need them? If yes, then let's introduce extension by extension in separate PR's (to be able to review). |
yes should be separated stuff in any case. As it's builtin extensions of VS Code, some other extensions may rely on their presence. for github* it's managed by Ihor but for others, we may check it they work on upstream theia/already have existing issue, etc. for theme-solarized-light it looks like only a missing copy/paste |
Issue to add Git* extensions eclipse-che/che#18281 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it a bit on Hosted Che by performing some basic operations. Works as expected. Thanks!
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com
What does this PR do?
Updates references to built-in plugin binaries.
Aligned with Theia upstream:
Updated to more fresh version:
Introduced (copied from upstream):
Left unchanged:
What issues does this PR fix or reference?
eclipse-che/che#17524
eclipse-che/che#17123
How to test this PR?
Use docker image, built by CI for this PR.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable