Introduce ESLint extension

[vitaliy-guliy]

Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com

What does this PR do?

Adds VS Code ESLint 2.1.1 extension to che-incubator/typescript plugin

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#14070

How to test this PR?

Devfile to test

---
apiVersion: 1.0.0
metadata:
  name: eslint-2.1.1
projects:
  -
    name: che-theia
    source:
      type: git
      location: "https://github.com/eclipse/che-theia.git"
components:
  # Che-Theia without built-in ES Lint from https://github.com/eclipse/che-theia/pull/923
  - type: cheEditor
    alias: che-theia
    reference: https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-923/che_theia_meta.yaml
    memoryLimit: 768Mi
  -
    type: chePlugin
    id: redhat/vscode-yaml/latest
  - 
    type: chePlugin
    id: ms-vscode/node-debug2/latest
    preferences:
      debug.node.useV3: false
  -
    type: chePlugin
    reference: https://raw.githubusercontent.com/eclipse/che-plugin-registry/eslint/v3/plugins/dbaeumer/vscode-eslint/2.1.1/meta.yaml
  # -
  #   type: chePlugin
  #   id: che-incubator/typescript/latest
  -
    alias: che-dev
    type: dockerimage
    image: quay.io/eclipse/che-theia-dev:next
    memoryLimit: "3Gi"
    mountSources: true
    endpoints:
      - name: 'theia-dev-flow'
      # - name: 'che-theia-link'
        port: 3010
        attributes:
          type: ide-dev
          protocol: http
          public: 'true'
          discoverable: 'false'
commands:
  -
    name: '1.1 che-theia :: build'
    actions:
      - type: exec
        component: che-dev
        workdir: /projects/che-theia
        command: |
          yarn
          echo -e "\e[32mDone.\e[0m"

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[che-bot]

@vitaliy-guliy Happy Path PR check [build 403] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/403/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/403/

Depending on failure reason, the artifacts or deployment may not be present.

[benoitf]

Hi, why eslint is in typescript plug-in ?

[vitaliy-guliy]

Hi, why eslint is in typescript plug-in ?

I just thought that's the best place for it. Do you have other ideas?
Whether it better to have an extra plugin to run eslint in the same container as Che-Theia?

[vitaliy-guliy]

As it appeared, VS Code ES Lint is already introduced to Che-Theia built-ins by eclipse-che/che-theia#902
And moreover, it works fine.

It could be tested with this devfile

---
apiVersion: 1.0.0
metadata:
  name: eslint-che-theia
projects:
  -
    name: che-theia
    source:
      type: git
      location: "https://github.com/eclipse/che-theia.git"
components:
  - type: cheEditor
    alias: che-theia
    reference: https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-902/che_theia_meta.yaml
    memoryLimit: 768Mi
  - type: chePlugin
    id: redhat/vscode-yaml/latest
  - 
    type: chePlugin
    id: ms-vscode/node-debug2/latest
    preferences:
      debug.node.useV3: false
  -
    alias: che-dev
    type: dockerimage
    image: quay.io/eclipse/che-theia-dev:next
    memoryLimit: "3Gi"
    mountSources: true
    endpoints:
      - name: 'theia-dev-flow'
      # - name: 'che-theia-link'
        port: 3010
        attributes:
          type: ide-dev
          protocol: http
          public: 'true'
          discoverable: 'false'
commands:
    name: '1.1 che-theia :: build'
    actions:
      - type: exec
        component: che-dev
        workdir: /projects/theia
        command: |
          yarn
          echo -e "\e[32mDone.\e[0m"

The editor was taken from the Devfile for Happy Path tests for PR 902

To test:

• create a workspace
• build Che-Theia or just install node dependencies
• open any typescript file and check ES Lint

This is what I got for variable declaration

When there is no new-line character at the end of the file

For a line, having trailing spaces

[benoitf]

I think it's a mistake that it went into built-in plug-ins
it's not a built-in

[che-bot]

@vitaliy-guliy Happy Path PR check [build 409] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/409/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/409/

Depending on failure reason, the artifacts or deployment may not be present.

[vitaliy-guliy]

I think it's a mistake that it went into built-in plug-ins
it's not a built-in

NP, will be extracted into separate Che-Plugin soon.

[che-bot]

@vitaliy-guliy Happy Path PR check [build 411] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/411/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/411/

Depending on failure reason, the artifacts or deployment may not be present.

[vitaliy-guliy]

Three versions of ES Lint were added.
One latest stable version will be left after testing.

[che-bot]

@vitaliy-guliy Happy Path PR check [build 412] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/412/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/412/

Depending on failure reason, the artifacts or deployment may not be present.

[vitaliy-guliy]

Only 2.1.1 version is stable and works without errors.
2.1.3 and 2.1.8 seems to be working, but have some issues with displaying the editor tooltip when hovering a mouse over a problem

Let's focus on 2.1.1, it's also included to upstream Theia built-ins https://github.com/eclipse-theia/theia/blob/e2098321a66e96e72248b555ca32063127857a98/package.json#L153

We need to investigate the reason of the console errors for 2.1.3 and 2.1.8. And then we can always create another PR with more fresh ES Lint.

[vitaliy-guliy]

Devfile to test 2.1.1

---
apiVersion: 1.0.0
metadata:
  name: eslint-2.1.1
projects:
  -
    name: che-theia
    source:
      type: git
      location: "https://github.com/eclipse/che-theia.git"
components:
  # Che-Theia without built-in ES Lint from https://github.com/eclipse/che-theia/pull/923
  - type: cheEditor
    alias: che-theia
    reference: https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-923/che_theia_meta.yaml
    memoryLimit: 768Mi
  -
    type: chePlugin
    id: redhat/vscode-yaml/latest
  - 
    type: chePlugin
    id: ms-vscode/node-debug2/latest
    preferences:
      debug.node.useV3: false
  -
    type: chePlugin
    reference: https://raw.githubusercontent.com/eclipse/che-plugin-registry/eslint/v3/plugins/dbaeumer/vscode-eslint/2.1.1/meta.yaml
  # -
  #   type: chePlugin
  #   id: che-incubator/typescript/latest
  -
    alias: che-dev
    type: dockerimage
    image: quay.io/eclipse/che-theia-dev:next
    memoryLimit: "3Gi"
    mountSources: true
    endpoints:
      - name: 'theia-dev-flow'
      # - name: 'che-theia-link'
        port: 3010
        attributes:
          type: ide-dev
          protocol: http
          public: 'true'
          discoverable: 'false'
commands:
  -
    name: '1.1 che-theia :: build'
    actions:
      - type: exec
        component: che-dev
        workdir: /projects/che-theia
        command: |
          yarn
          echo -e "\e[32mDone.\e[0m"

[che-bot]

@vitaliy-guliy Happy Path PR check [build 416] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/416/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/416/

Depending on failure reason, the artifacts or deployment may not be present.

[che-bot]

@vitaliy-guliy Happy Path PR check [build 417] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/417/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/417/

Depending on failure reason, the artifacts or deployment may not be present.

[che-bot]

@vitaliy-guliy Happy Path PR check [build 418] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/418/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/418/

Depending on failure reason, the artifacts or deployment may not be present.

[che-bot]

@vitaliy-guliy Happy Path PR check [build 421] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/421/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/421/

Depending on failure reason, the artifacts or deployment may not be present.