Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons for tabs are not displayed #17978

Closed
3 of 22 tasks
dmytro-ndp opened this issue Sep 28, 2020 · 14 comments
Closed
3 of 22 tasks

Icons for tabs are not displayed #17978

dmytro-ndp opened this issue Sep 28, 2020 · 14 comments
Assignees
@RomanNikitenko
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.20

Comments

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Sep 28, 2020 •
edited by RomanNikitenko
Loading

Describe the bug

Icons are absent for different kinds of tabs: task tab, terminal tab, editor tab.
Please see #17978 (comment)

The issue is blocking an update Devfile E2E tests and GitSSH flow E2E tests #17973.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Start nightly Eclipse Che
  2. Create and open Java maven workspace
  3. Open any file, terminal or run a task

Expected behavior

A tab contains the corresponding icon:
tabs_expected_behavior

Actual wrong result

There are no icons for tabs:
tabs_actual_behavior

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube 1.1.1
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Eclipse Che Logs

Additional context
@dmytro-ndp dmytro-ndp added kind/bug Outline of a bug - must adhere to the bug report template. area/editor/theia Issues related to the che-theia IDE of Che area/editors labels Sep 28, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 28, 2020
@dmytro-ndp dmytro-ndp added the severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. label Sep 28, 2020
@azatsarynnyy azatsarynnyy added area/plugins and removed area/editor/theia Issues related to the che-theia IDE of Che area/editors severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 28, 2020
@dmytro-ndp dmytro-ndp mentioned this issue Sep 28, 2020
Closed
22 tasks
@dmytro-ndp dmytro-ndp added the severity/P1 Has a major impact to usage or development of the system. label Sep 28, 2020
@RomanNikitenko
Copy link
Member

RomanNikitenko commented Sep 28, 2020 •
edited
Loading

Tested on che-dogfooding instance - can not reproduce it.

status_icon_dogfood_instance

@azatsarynnyy
Copy link
Member

@dmytro-ndp is it stable reproducible or does it requires some specific environment, devfile, etc.

@azatsarynnyy azatsarynnyy added area/editor/theia Issues related to the che-theia IDE of Che and removed area/plugins labels Sep 28, 2020
@azatsarynnyy
Copy link
Member

@dmytro-ndp It seems we were modifying the issue labels at the same time
That's why it shows I removed the blocker from it. It's done not on purpose 🙂
Feel free to re-check the labels and correct it if needed.

@RomanNikitenko
Copy link
Member

Tested on https://che.openshift.io/ - can not reproduce the bug

status_icon_openshift

@azatsarynnyy azatsarynnyy added the status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. label Sep 28, 2020
@azatsarynnyy
Copy link
Member

@dmytro-ndp is it stable reproducible or does it requires some specific environment, devfile, etc.

@dmytro-ndp could you also attach the screenshot of Help>About dialog to check what version is used in your case?

@dmytro-ndp
Copy link
Contributor Author

@azatsarynnyy, @RomanNikitenko: I also can't reproduce it on che.openshift.io in workpsace having changes from corresponding PR https://che.openshift.io/f/?url=https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-823/simple/che-theia-maven-devfile.yaml

@dmytro-ndp
Copy link
Contributor Author

@azatsarynnyy

@dmytro-ndp could you also attach the screenshot of Help>About dialog to check what version is used in your case?

It's nightly version of che-theia: quay.io/eclipse/che-theia@sha256:3be78bf018b54eb6a8cf518a85cda95973cb831652819003e43c234116f3aa05

@dmytro-ndp
Copy link
Contributor Author

@RomanNikitenko, @azatsarynnyy: I have reproduced an issue on Eclipse Che nightly instance on QE OCP https://che-nightly-che.apps.ocp45.crw-qe.com/dashboard/#/ide/admin/apache-camel-k-sxln1?tab=getStarted
Screenshot from 2020-09-28 18-37-43

@RomanNikitenko
Copy link
Member

@dmytro-ndp
Nice!

But from your screenshot I see that a task was not started at all
I tried your link and see that behavior as well
error_task

I thought that E2E tests were failed because they were waiting successfully completed task #17973
isn't it?

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Sep 28, 2020 •
edited
Loading

@dmytro-ndp
I played a little with the instance that you provided and can reproduce the issue for started tasks and different statuses.
So, looks like we can use this instance to debug the corresponding code and fix the issue.

Thank you very much for your help, Dmytro!

@dmytro-ndp
Copy link
Contributor Author

@RomanNikitenko: you are right about the test.
Actually, the issue is about task status icon, which isn't been shown doesn't matter if it's successful, error, or in-progress task:
Screenshot from 2020-09-28 19-02-12

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Sep 28, 2020 •
edited
Loading

Actually, the issue is about task status icon, which isn't been shown doesn't matter if it's successful, error, or in-progress task

I understand, but technically the causes of the problems are different for already started task and not started at all.
To fix E2E tests it was important to reproduce the issue for already started tasks.
That's why I asked about it.

As I mentioned above #17978 (comment) I can reproduce the issue using instance that you provided and we can use this one to debug the corresponding code and fix the issue.

@azatsarynnyy azatsarynnyy removed the status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. label Sep 29, 2020
@azatsarynnyy azatsarynnyy added this to the 7.20 milestone Sep 29, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Sep 29, 2020
Closed
18 tasks
@RomanNikitenko RomanNikitenko added the status/in-progress This issue has been taken by an engineer and is under active development. label Sep 29, 2020
@RomanNikitenko
Copy link
Member

RomanNikitenko commented Sep 29, 2020 •
edited
Loading

@dmytro-ndp
For the instance that you provided I see that icons are absent for different kinds of tabs: task tab, terminal tab, editor tab. So the issue is more global.

Expected:
tabs_expected_behavior

Actual:
tabs_actual_behavior

btw: you can see it on your screenshots as well, here for example: #17978 (comment)

@RomanNikitenko RomanNikitenko changed the title Status icons for vs code tasks are not displayed Icons for tabs are not displayed Sep 29, 2020
@dmytro-ndp
Copy link
Contributor Author

@RomanNikitenko: good catch, thank you!

@Katka92 Katka92 mentioned this issue Oct 1, 2020
Merged
9 tasks
@RomanNikitenko RomanNikitenko mentioned this issue Oct 6, 2020
Merged
@RomanNikitenko RomanNikitenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Oct 6, 2020
@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanNikitenko RomanNikitenko

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.20
Development

No branches or pull requests
4 participants
@dmytro-ndp @azatsarynnyy @RomanNikitenko @che-bot