Implement C/C++ devfile test #18009

ScrewTSW · 2020-10-01T07:52:23Z

What does this PR do?

Implements tests for new C/C++ devfile

What issues does this PR fix or reference?

#17709

How to test this PR?

Go into Eclipse repository che/tests/e2e
Run npm i and verify that all packages install without errors
Run tsc and verify that no errors are present
Export following variables:
- TS_SELENIUM_BASE_URL
- TS_SELENIUM_MULTIUSER=true
- NODE_TLS_REJECT_UNAUTHORIZED=0
- TS_SELENIUM_LOG_LEVEL="TRACE"
- TS_SELENIUM_USERNAME
- TS_SELENIUM_PASSWORD
Run npm run test-java-vertx to execute the smoke test devfile and verify that the tests are working correctly or run entire suite using npm run test-all-devfiles
Tests should pass without a failure (you may encounter stop and delete workspace failures if not using ephemeral mode by default)

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

che-bot · 2020-10-01T07:57:27Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18009

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

ScrewTSW · 2020-10-01T08:01:10Z

[crw-ci-test]

che-bot · 2020-10-01T08:07:22Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18009

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

che-bot · 2020-10-01T08:53:17Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:18009

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Katka92 · 2020-10-01T09:26:00Z

tests/e2e/tests/devfiles/Go.spec.ts

        commonLsTests.errorHighlighting(fileName, 'error;\n', 42);
-        // commonLsTests.codeNavigation(fileName, 42, 10, 'flag.go'); // codenavigation is inconsistent https://github.com/eclipse/che/issues/16929
+        // commonLsTests.codeNavigationGoTo(fileName, 42, 10, 'flag.go'); // codenavigation is inconsistent https://github.com/eclipse/che/issues/16929


Can it be fixed and uncommented by you're new functionality?

Katka92 · 2020-10-01T09:34:45Z

tests/e2e/testsLibrary/LsTests.ts


- export function codeNavigation(openedFile: string, line: number, char: number, codeNavigationClassName: string) {
-    test('Codenavigation', async () => {
+export function codeNavigationGoTo(openedFile: string, line: number, char: number, codeNavigationClassName: string, keyCombination: string = Key.chord(Key.CONTROL, Key.F12)) {


I'm not sure if GoTo is adding any value here - the codeNavigation already says that you should be navigated somewhere. Maybe it would be worth adding if it should redirect you to implementation, definition, references...

I wanted to prepare it for the two approaches: codeNavigationGoTo and codeNavigationPeek as is explained in this issue: #17995

I see, so what about renaming this method to codeNavigationGoToImplementation?

Not necessarily, because based on what key combination we send, we can go do Definition, Implementation, References, etc.

GoTo - we expect it to open a new file
Peek - we expect it to show the in-editor peek window

Katka92 · 2020-10-01T09:40:08Z

tests/e2e/tests/devfiles/Go.spec.ts

@@ -46,7 +46,7 @@ suite(`${workspaceStack} test`, async () => {
        projectManager.openFile(fileFolderPath, fileName);
    });

-    suite('Test golang example', async () => {
+    suite.skip('Test golang example', async () => { // test always fails, because the task does not show a notification about return code


I'm not sure about skipping this test. In 7.19.x the notification was removed in all stacks so we would need to switch to another approach. I prefer to leave it unskipped.
issue for fix: #17973 (comment)
upstream PR with the change: eclipse-theia/theia#8331
blocker for implementing the fix: #17978

but if it will be unskipped, it will be causing test failures

Well, but then it means that it should be skipped in all the devfile tests - I don't see much value in skipping that just in one of them.

I will test it on latest che and skip where necessary

Katka92

Please revert the skipping of test for command in Go. Others are just minor items.

che-bot · 2020-10-05T08:43:42Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:18009

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ScrewTSW · 2020-10-06T11:24:17Z

I've split the current PR into only C/C++ implementation and improvements that can be found here master...ScrewTSW:local_optimizing_devfile_tests

Signed-off-by: Tibor Dancs <tdancs@redhat.com>

che-bot · 2020-10-06T11:50:54Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:18009

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ScrewTSW added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/che-qe area/qe labels Oct 1, 2020

ScrewTSW requested review from Ohrimenko1988 and Katka92 October 1, 2020 07:52

ScrewTSW requested review from l0rd, musienko-maxim, nickboldt and rhopp as code owners October 1, 2020 07:52

ScrewTSW changed the title ~~17709 feature implement cslashcplusplus devfile test~~ 17709 Implement C/C++ devfile test Oct 1, 2020

ScrewTSW force-pushed the 17709-feature-implement-cslashcplusplus-devfile-test branch from 168540e to b23ba2a Compare October 1, 2020 08:34

Katka92 reviewed Oct 1, 2020

View reviewed changes

Katka92 requested changes Oct 1, 2020

View reviewed changes

ScrewTSW force-pushed the 17709-feature-implement-cslashcplusplus-devfile-test branch from b23ba2a to c7854b0 Compare October 5, 2020 08:27

ScrewTSW changed the title ~~17709 Implement C/C++ devfile test~~ WIP: Implement C/C++ devfile test Oct 5, 2020

ScrewTSW force-pushed the 17709-feature-implement-cslashcplusplus-devfile-test branch from c7854b0 to 25f9681 Compare October 6, 2020 11:18

Added test implementation for C/C++ devfile

16b6adb

Signed-off-by: Tibor Dancs <tdancs@redhat.com>

ScrewTSW force-pushed the 17709-feature-implement-cslashcplusplus-devfile-test branch from 25f9681 to 16b6adb Compare October 6, 2020 11:29

ScrewTSW changed the title ~~WIP: Implement C/C++ devfile test~~ Implement C/C++ devfile test Oct 6, 2020

Katka92 approved these changes Oct 7, 2020

View reviewed changes

ScrewTSW merged commit 286a222 into eclipse-che:master Oct 7, 2020

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 7, 2020

che-bot added this to the 7.20 milestone Oct 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement C/C++ devfile test #18009

Implement C/C++ devfile test #18009

ScrewTSW commented Oct 1, 2020 •

edited

Loading

che-bot commented Oct 1, 2020

ScrewTSW commented Oct 1, 2020

che-bot commented Oct 1, 2020

che-bot commented Oct 1, 2020

Katka92 Oct 1, 2020

Katka92 Oct 1, 2020

ScrewTSW Oct 1, 2020

Katka92 Oct 2, 2020

ScrewTSW Oct 2, 2020

ScrewTSW Oct 2, 2020

Katka92 Oct 1, 2020 •

edited

Loading

ScrewTSW Oct 1, 2020

Katka92 Oct 2, 2020

ScrewTSW Oct 2, 2020

Katka92 left a comment

che-bot commented Oct 5, 2020

ScrewTSW commented Oct 6, 2020

che-bot commented Oct 6, 2020

Implement C/C++ devfile test #18009

Implement C/C++ devfile test #18009

Conversation

ScrewTSW commented Oct 1, 2020 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

che-bot commented Oct 1, 2020

ScrewTSW commented Oct 1, 2020

che-bot commented Oct 1, 2020

che-bot commented Oct 1, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Katka92 Oct 1, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Katka92 left a comment

Choose a reason for hiding this comment

che-bot commented Oct 5, 2020

ScrewTSW commented Oct 6, 2020

che-bot commented Oct 6, 2020

ScrewTSW commented Oct 1, 2020 •

edited

Loading

Katka92 Oct 1, 2020 •

edited

Loading